-
Notifications
You must be signed in to change notification settings - Fork 769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deprecate Py::as_ref #3864
deprecate Py::as_ref #3864
Conversation
CodSpeed Performance ReportMerging #3864 will improve performances by 13.43%Comparing Summary
Benchmarks breakdown
|
dede4d3
to
fcd5f8e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Agreed re docs can be follow-up; for the remaining pieces I've left some suggestions...
Co-authored-by: David Hewitt <[email protected]>
Co-authored-by: David Hewitt <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great to me, thanks! 🚀
👍 yes I'm looking forward to using format argument capture when we bump MSRV 😅 |
I think rewriting the docs to use the new API can happen in a different PR. The other outstanding bits I think will also be tidied up in other work.