Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

actions/runner-images deprecating macos-12 #2249

Closed
1 of 2 tasks
2bndy5 opened this issue Oct 10, 2024 · 3 comments · Fixed by #2255
Closed
1 of 2 tasks

actions/runner-images deprecating macos-12 #2249

2bndy5 opened this issue Oct 10, 2024 · 3 comments · Fixed by #2255
Labels
bug Something isn't working

Comments

@2bndy5
Copy link

2bndy5 commented Oct 10, 2024

Bug Description

I just came across this warning in my CI workflow's summary (originating from job that builds x86_64 target on macos-12):

A brownout will take place on November 4, 14:00 UTC - November 5, 00:00 UTC to raise awareness of the upcoming macOS-12 environment removal. For more details, see actions/runner-images#10721

So, I was wondering if it is ok to migrate to macos-14 instead? I don't own a Mac to test/build locally.

Your maturin version (maturin --version)

v1.7.4

Your Python version (python -V)

3.12.6

Your pip version (pip -V)

whatever is setup in runner's tool cache (using python-version: 3.x)

What bindings you're using

pyo3

Does cargo build work?

  • Yes, it works

If on windows, have you checked that you aren't accidentally using unix path (those with the forward slash /)?

  • Yes

Steps to Reproduce

  1. Run maturin generate-ci on existing project or maturin new <pkg-name>
  2. Push generated workflow to GitHub remote
  3. Review workflow run's summary. Notice the "Annotations" section below the workflow's diagram.
@2bndy5 2bndy5 added the bug Something isn't working label Oct 10, 2024
@2bndy5
Copy link
Author

2bndy5 commented Oct 10, 2024

If this is not considered a bug and should instead be a discussion, please transfer the issue accordingly.

@messense
Copy link
Member

#2246

@messense messense linked a pull request Oct 10, 2024 that will close this issue
@2bndy5
Copy link
Author

2bndy5 commented Oct 10, 2024

Oh I didn't see that PR. For the record, I did do a 'macos' search on open/closed issues/discussions. I didn't think to check PRs though. Glad to see you folks are already tracking it. I guess I'll leave this open since it will auto-close when #2246 is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants