Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing description of the Rosenbrock function in documentation #162

Closed
ewu63 opened this issue Feb 22, 2024 · 2 comments · Fixed by #165
Closed

Missing description of the Rosenbrock function in documentation #162

ewu63 opened this issue Feb 22, 2024 · 2 comments · Fixed by #165

Comments

@ewu63
Copy link

ewu63 commented Feb 22, 2024

This is part of the review at openjournals/joss-reviews#6326.

On this page, the line

For this example we will use the well-known Rosenbrock function:

should be followed by a mathematical description of the Rosenbrock function, but only a generic function is presented.
@mrava87 mrava87 mentioned this issue Feb 24, 2024
Merged
@mrava87
Copy link
Contributor

mrava87 commented Feb 24, 2024

@nwu63 Good idea, added here #165, what do you think?

@ewu63
Copy link
Author

ewu63 commented Feb 26, 2024

@nwu63 Good idea, added here #165, what do you think?

Looks great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

doc: Added Rosebrock function definition mrava87/pyproximal
2 participants
@ewu63 @mrava87