Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adaptive-FISTA #323

Open
mrava87 opened this issue Feb 6, 2022 · 5 comments
Open

Adaptive-FISTA #323

mrava87 opened this issue Feb 6, 2022 · 5 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@mrava87
Copy link
Collaborator

mrava87 commented Feb 6, 2022

Feature

Recently an Adaptive-FISTA algorithm was introduced in https://www.earthdoc.org/content/papers/10.3997/2214-4609.202229010. This algorithm shows faster convergence for problems where the model is expected to be very sparse (as it approximates the L0 norm).

Implementation

@NickLuiken will implement this in pylops.optimization.sparsity.ISTA and pylops.optimization.sparsity.FISTA

@mrava87 mrava87 added enhancement New feature or request good first issue Good for newcomers labels Feb 6, 2022
@cako
Copy link
Collaborator

cako commented Feb 11, 2022

Looks very promising. Would be interested to see if this means we can relax having to know the maximum eigenvalue. Maybe setting a sufficiently large value is enough under this adaptive scheme. Looking forward to seeing this!

@mrava87
Copy link
Collaborator Author

mrava87 commented Feb 12, 2022

Good point! We haven’t looked into this but definitely for some problem where you can’t tell upfront the eigenvalue, not having to know it with high accuracy would be a bit plus :)

@cako
Copy link
Collaborator

cako commented May 16, 2022

Now that #90 is closed, it would be interesting to convert the AFISTA code into a class-based solver:
https://github.com/PyLops/pylops_transform2022/blob/main/afista.py

@mrava87 @NickLuiken

@rohanbabbar04
Copy link
Contributor

Hi @cako @mrava87, If this issue is not touched upon, would like to work on it.

@mrava87
Copy link
Collaborator Author

mrava87 commented Feb 1, 2023

Hi, this issue is already taken, we just need to move codes around so no point for you to look into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants