Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use native PyTorch complex number support #17

Open
anjali411 opened this issue Apr 3, 2022 · 1 comment
Open

Use native PyTorch complex number support #17

anjali411 opened this issue Apr 3, 2022 · 1 comment

Comments

@anjali411
Copy link

I noticed that you are using ComplexTensor and ComplexScalar classes to store complex numbers https://github.com/PyLops/pylops-gpu/blob/eed70f1973f01f31ef905fe09bb88c8783fd9681/pylops_gpu/utils/complex.py However, that's not necessary since latest releases of PyTorch (1.7 and after) support native complex support with specialized kernels for complex numbers for most PyTorch ops!

@mrava87
Copy link
Collaborator

mrava87 commented May 23, 2022

Thanks. If you are interested to contribute changes we will be happy to switch to native pytorch complex number.

However, note that we are not developing this library further because we have added full GPU support in pylops via a cupy backend. I am going to update the README file to make people aware of this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants