Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setinfo does not set modification time #64

Open
jwnimmer-tri opened this issue Nov 19, 2019 · 0 comments
Open

setinfo does not set modification time #64

jwnimmer-tri opened this issue Nov 19, 2019 · 0 comments

Comments

@jwnimmer-tri
Copy link

The current implementation of fs_s3fs.S3FS.setinfo() just a call to self.getinfo() (presumably to validate the path name).

However, if the call to setinfo() was due to trying to set the modification time as per fs.base.FS.settimes(), then the result appears to be no change to the modification time.

Perhaps until modification-time updates are correctly set by s3fs, it should raise NotImplementedError in this case for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant