Skip to content
This repository has been archived by the owner on Jun 21, 2023. It is now read-only.

AlgoSigner is not added to window global in certain cases #475

Open
gabrielkuettel opened this issue Jan 31, 2023 · 1 comment
Open

AlgoSigner is not added to window global in certain cases #475

gabrielkuettel opened this issue Jan 31, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@gabrielkuettel
Copy link

I believe this may be a related closed issue:
#396

In some cases, it appears that AlgoSigner does not attach itself to the window global. It seems to happen after a page refresh. But it's intermittent and hard to debug.

Also, noticed that AlgoSigner does not inject itself to window if opening a blank tab, or on localhost. Is that behavior documented anywhere?

Just looking for more information so I can figure out how to reproduce/debug this issue. Thanks.

@janmarcano janmarcano added the bug Something isn't working label Feb 14, 2023
@janmarcano
Copy link
Contributor

janmarcano commented Feb 14, 2023

we'll try to take a second look into the injection issue on refreshes

regarding it not injecting on a blank tab:
we inject the AlgoSigner object on all the URL schemes that Chrome allows us to via the content script, Google has their own criteria on what is a valid or invalid URL scheme
for the localhost issue, you could try with 127.0.0.1 as that does appear to match according to the Chrome docs

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants