From 3cecae815a1b7ea8e20f303e6b1920a56a736834 Mon Sep 17 00:00:00 2001 From: Brent Date: Thu, 24 Mar 2022 17:39:13 -0400 Subject: [PATCH] UI transaction note fix for Ledger --- README.md | 4 ++++ package.json | 2 +- packages/common/package.json | 2 +- packages/crypto/package.json | 2 +- packages/dapp/package.json | 2 +- packages/extension/manifest.json | 2 +- packages/extension/package.json | 2 +- packages/storage/package.json | 2 +- packages/test-project/package.json | 2 +- packages/ui/package.json | 2 +- .../ui/src/components/LedgerDevice/structure/ledgerActions.ts | 4 ++++ 11 files changed, 17 insertions(+), 9 deletions(-) diff --git a/README.md b/README.md index daac36ab..bd2d1837 100644 --- a/README.md +++ b/README.md @@ -21,6 +21,10 @@ This update is focused around rekey and changes to accommodate it. Both normal a - Transactions with rekeyed accounts now accepted - Reference accounts can now be imported with public key only +### Patch 1.8.3 + +Fix for transaction notes created in the UI and signed with a Ledger device. + ### Patch 1.8.2 Fix for Ledger transactions created in the UI with transfer amounts set to 0. diff --git a/package.json b/package.json index 972b9bd8..600b3866 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "algosigner", - "version": "1.8.2", + "version": "1.8.3", "author": "https://developer.purestake.io", "description": "Sign Algorand transactions in your browser with PureStake.", "repository": "https://github.com/PureStake/algosigner", diff --git a/packages/common/package.json b/packages/common/package.json index 0cd6d2af..0ed69d83 100644 --- a/packages/common/package.json +++ b/packages/common/package.json @@ -1,6 +1,6 @@ { "name": "@algosigner/common", - "version": "1.8.2", + "version": "1.8.3", "author": "https://developer.purestake.io", "description": "Common library functions for AlgoSigner.", "repository": "https://github.com/PureStake/algosigner", diff --git a/packages/crypto/package.json b/packages/crypto/package.json index 7ca12bb6..df721afa 100644 --- a/packages/crypto/package.json +++ b/packages/crypto/package.json @@ -1,6 +1,6 @@ { "name": "algosigner-crypto", - "version": "1.8.2", + "version": "1.8.3", "author": "https://developer.purestake.io", "description": "Cryptographic wrapper for saving and retrieving extention information in Algosigner.", "repository": { diff --git a/packages/dapp/package.json b/packages/dapp/package.json index cef1cada..bb0e389c 100644 --- a/packages/dapp/package.json +++ b/packages/dapp/package.json @@ -1,6 +1,6 @@ { "name": "@algosigner/dapp", - "version": "1.8.2", + "version": "1.8.3", "author": "https://developer.purestake.io", "repository": "https://github.com/PureStake/algosigner", "license": "MIT", diff --git a/packages/extension/manifest.json b/packages/extension/manifest.json index 30d0df7a..eee25f89 100644 --- a/packages/extension/manifest.json +++ b/packages/extension/manifest.json @@ -2,7 +2,7 @@ "manifest_version": 2, "name": "AlgoSigner", "author": "https://developer.purestake.io", - "version": "1.8.2", + "version": "1.8.3", "description": "Algorand Wallet Extension | Send & Receive ALGOs | Sign dApp Transactions", "icons": { "48": "icon.png" diff --git a/packages/extension/package.json b/packages/extension/package.json index 5939cf72..f9702d6d 100644 --- a/packages/extension/package.json +++ b/packages/extension/package.json @@ -1,6 +1,6 @@ { "name": "algosigner-extension", - "version": "1.8.2", + "version": "1.8.3", "author": "https://developer.purestake.io", "repository": "https://github.com/PureStake/algosigner", "license": "MIT", diff --git a/packages/storage/package.json b/packages/storage/package.json index ef3e8202..53cf0481 100644 --- a/packages/storage/package.json +++ b/packages/storage/package.json @@ -1,6 +1,6 @@ { "name": "algosigner-storage", - "version": "1.8.2", + "version": "1.8.3", "author": "https://developer.purestake.io", "repository": "https://github.com/PureStake/algosigner", "license": "MIT", diff --git a/packages/test-project/package.json b/packages/test-project/package.json index 51d1ac06..d144d70f 100644 --- a/packages/test-project/package.json +++ b/packages/test-project/package.json @@ -1,6 +1,6 @@ { "name": "algorand-test-project", - "version": "1.8.2", + "version": "1.8.3", "repository": "https://github.com/PureStake/algosigner", "license": "MIT", "description": "Repository for tests", diff --git a/packages/ui/package.json b/packages/ui/package.json index f7d2fbec..d9032796 100644 --- a/packages/ui/package.json +++ b/packages/ui/package.json @@ -1,6 +1,6 @@ { "name": "algosigner-ui", - "version": "1.8.2", + "version": "1.8.3", "author": "https://developer.purestake.io", "repository": "https://github.com/PureStake/algosigner", "license": "MIT", diff --git a/packages/ui/src/components/LedgerDevice/structure/ledgerActions.ts b/packages/ui/src/components/LedgerDevice/structure/ledgerActions.ts index 2dcd8c30..bcc75814 100644 --- a/packages/ui/src/components/LedgerDevice/structure/ledgerActions.ts +++ b/packages/ui/src/components/LedgerDevice/structure/ledgerActions.ts @@ -175,6 +175,10 @@ function cleanseBuildEncodeUnsignedTransaction(transaction: any): any { } } + if ('note' in removedFieldsTxn){ + removedFieldsTxn['note'] = new Uint8Array(Buffer.from(removedFieldsTxn['note'])); + } + const builtTx = new Transaction(removedFieldsTxn); const byteTxn = algosdk.encodeUnsignedTransaction(builtTx);