Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Middle border appears when using Selection Border #80

Open
brownt4 opened this issue Feb 11, 2016 · 3 comments
Open

Middle border appears when using Selection Border #80

brownt4 opened this issue Feb 11, 2016 · 3 comments
Labels
bug

Comments

@brownt4
Copy link

brownt4 commented Feb 11, 2016

I am not sure if this is intended, but it seems that when you highlight a partial line it adds a border in the middle of the selection. See attached example:
screen shot 2016-02-11 at 09 08 50
@richrace richrace added the bug label Feb 11, 2016
@AvonGenesis
Copy link

I have this same issue. Reverting #70 seems to have fixed the issue for me.

@josephponte
Copy link

Me too running Windows 7.

atombug1

@kedare
Copy link

kedare commented Apr 8, 2017

Same issue here on OSX,
Any way to solve this ?

DoughnutSlayer added a commit to DoughnutSlayer/highlight-line that referenced this issue Nov 5, 2017
@DoughnutSlayer
Fix Issue Pulsar-Edit-Highlights#80
1bbbdcf 
Rather than always setting the start point of the bottom line to the
second to last row, only do so if the selection on the last row is
empty.

Before, the last two rows would be underlined if anything on the last
row was selected, because the bottom line would start on the second to
last row and ended on the last row.
DoughnutSlayer added a commit to DoughnutSlayer/highlight-line that referenced this issue Nov 5, 2017
@DoughnutSlayer
Fix Issue Pulsar-Edit-Highlights#80
83e4c4b
@DoughnutSlayer DoughnutSlayer mentioned this issue Nov 5, 2017
Merged
richrace added a commit that referenced this issue Oct 28, 2020
@richrace
Merge pull request #89 from DoughnutSlayer/issue-80
3b6bb04 
Fix Issue #80
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@kedare @AvonGenesis @richrace @brownt4 @josephponte