Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WS authentication failure should throw an error #24

Open
devnote-dev opened this issue May 8, 2023 · 0 comments
Open

WS authentication failure should throw an error #24

devnote-dev opened this issue May 8, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@devnote-dev
Copy link
Member

Currently when a websocket authentication fails, there is no indication of this to the end-user, and the websocket connection will stay alive despite not receiving anything from the server. Instead, the websocket should throw an error when authentication fails. This would mean that Shard#launch() would now be error-prone, I'm not sure if that should be considered a breaking change.

@devnote-dev devnote-dev added the enhancement New feature or request label May 8, 2023
@devnote-dev devnote-dev self-assigned this May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant