Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AudioUtil: .sf2 all looped samples are pitched too high #46

Open
IsoFrieze opened this issue Jun 30, 2019 · 1 comment
Open

AudioUtil: .sf2 all looped samples are pitched too high #46

IsoFrieze opened this issue Jun 30, 2019 · 1 comment
Labels

Comments

@IsoFrieze
Copy link

I noticed when playing back certain songs, some instruments sound very out of tune, some more than others (synths especially). I also found that this was already a known issue for a while, but I found the cause.
Every looped sample starts looping one sample too late. This causes the pitch to rise, and for shorter loops, this increase in frequency is greatly exaggerated.
To see if I could fix it, I opened the .sf2 output from audioutil in Polyphone, a soundfont editor. In the attached images you can easily tell that the loop is incorrect, and decrementing the loop beginning point by one fixes it. I have confirmed this by fixing a handful of samples and playing sounds that use them.
This effects all looped samples--there's probably an off-by-one error somewhere.
sample309
sample307

@PsyCommando
Copy link
Owner

Did you use the latest binary or latest version on the repo? Its been a while and I think that I messed with the loop points since then.

@PsyCommando PsyCommando added the bug label Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants