Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debian build script does not build the Rust library? #2

Open
3 tasks done
antermin opened this issue Oct 9, 2024 · 2 comments
Open
3 tasks done

Debian build script does not build the Rust library? #2

antermin opened this issue Oct 9, 2024 · 2 comments

Comments

@antermin
Copy link

antermin commented Oct 9, 2024

We are happy to answer your questions about the code or discuss technical ideas.

Please complete the following checklist (by adding [x]):

  • I have searched open and closed issues for duplicates
  • This isn't a feature request
  • This is not a report about my app not working as expected

https://github.com/ProtonVPN/python-proton-vpn-local-agent/blob/master/python-proton-vpn-local-agent/debian/rules

It looks like the build script assumes a built Rust library is present, and as such the user has to first manually build the library first before they can build the Debian package?

@calexandru2018
Copy link
Member

@antermin if you check the readme it explains how to go about it.

@antermin
Copy link
Author

antermin commented Oct 9, 2024

https://github.com/ProtonVPN/python-proton-vpn-local-agent/blob/01332194d217d91a514ecaebcdfbfa3d21ccd1ed/python-proton-vpn-local-agent/debian/rules#L6-L7

Currently the build: section does nothing, but wouldn't it be better to build the Rust library in this section?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants