bridge uses pass(1) even though "Helper" is "secret-service"

[brunnre8]

Expected Behavior

When the keychain helper is set to "secret-service" or "secret-service-dbus" all other helpers should not be tried

Current Behavior

All possible helpers are used in the setup, due to the isUsable() checks in init() of pkg/keychain/helper_linux.go

proton-bridge/pkg/keychain/helper_linux.go

Lines 75 to 105 in 384154c

	func isUsable(helper credentials.Helper, err error) bool {
	l := logrus.WithField("helper", reflect.TypeOf(helper))
	if err != nil {
	l.WithError(err).Warn("Keychain helper couldn't be created")
	return false
	}
	creds := &credentials.Credentials{
	ServerURL: "bridge/check",
	Username: "check",
	Secret: "check",
	}
	if err := helper.Add(creds); err != nil {
	l.WithError(err).Warn("Failed to add test credentials to keychain")
	return false
	}
	if _, _, err := helper.Get(creds.ServerURL); err != nil {
	l.WithError(err).Warn("Failed to get test credentials from keychain")
	return false
	}
	if err := helper.Delete(creds.ServerURL); err != nil {
	l.WithError(err).Warn("Failed to delete test credentials from keychain")
	return false
	}
	return true
	}

This messes up keychains that track history, in my case pass, as that adds multiple entries whenever the bridge starts.
If the bridge has explicitly been told to use a certain keychain, all others should not be touched even if they seem to be available.

Possible Solution

Don't check for usability of helpers that are not configured if the user explicitly set a helper in the config

Steps to Reproduce

1. Install pass, make it use the git integration
2. configure the bridge to use the secret-service helper
3. check the pass git log entries, you'll see a add + remove for every invocation of the bridge

Version Information

v3.4.2 (br-165)

[LBeernaertProton]

Thanks for the report. Internally tracked as GODT-2961.

[DarkArc]

I haven't bumped into this in a while ... today when rebooting I lost credentials and had to sign in again.

[droople1]

Also see #472 If protonmail doesn't want to work for gnome-keyring for whatever reason, but it works fine with pass, then you still have to wait for it to timeout with the other items because pass is checked last.