Fix json #70
Merged
Fix json #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enryH
approved these changes
Jul 10, 2023
vedran-kasalica
requested changes
Jul 13, 2023
There was a problem hiding this comment.
I agree with the changes, they solve Issue #65. I would recommend using the same on line 23 of the same file (as part of the write_json_local_development method).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fairly straightforward fix of writing valid JSON.
Downstream testing after accepting PR and merging this into Proteobench:
Proteobot/Results_quant_ion_DDA@3df7832
Also see: #65