Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

449 add raw file names next to link to pxd #493

Merged
merged 5 commits into from
Dec 12, 2024

Conversation

mlocardpaulet
Copy link
Contributor

I added the direct links to the raw files on PRIDE.
I also homogenised the markdown texts in the tabs Submit your data, but please make sure you agree @rodvrees. And you can of course change back if you don't.
In particular: I removed the list of compatible software for the DIA module because:

  1. it is not in the DDA modules
  2. the information is in the selection box
  3. it is a bit harder to keep up to date.
    But I don't feel strongly about it. I am totally fine if you want to revert it to how it was.

I also put back the mention of the contaminants in MQ to homogenise, but I know that @RobbinBouwmeester removed it in the past. If you want I can remove it again, although I think that it can be good to keep it since it highlights that everything is included in the fasta and people who routinely use their own (with or without MQ) may think of not doing so. But remove is you dislike ;)

@mlocardpaulet mlocardpaulet linked an issue Dec 12, 2024 that may be closed by this pull request
@RobbinBouwmeester RobbinBouwmeester merged commit 4fdb82b into main Dec 12, 2024
8 checks passed
@RobbinBouwmeester RobbinBouwmeester deleted the 449-add-raw-file-names-next-to-link-to-pxd branch December 12, 2024 12:19
@RobbinBouwmeester
Copy link
Contributor

I added the direct links to the raw files on PRIDE. I also homogenised the markdown texts in the tabs Submit your data, but please make sure you agree @rodvrees. And you can of course change back if you don't. In particular: I removed the list of compatible software for the DIA module because:

  1. it is not in the DDA modules
  2. the information is in the selection box
  3. it is a bit harder to keep up to date.
    But I don't feel strongly about it. I am totally fine if you want to revert it to how it was.

I also put back the mention of the contaminants in MQ to homogenise, but I know that @RobbinBouwmeester removed it in the past. If you want I can remove it again, although I think that it can be good to keep it since it highlights that everything is included in the fasta and people who routinely use their own (with or without MQ) may think of not doing so. But remove is you dislike ;)

Did I remove that? Not sure why I did that... If you ask me now I think it makes sense to include

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add raw file names next to link to PXD
2 participants