Transition settings TransitionFilter.Equals was not considering its _smallMoleculeFragmentAdducts member… #3185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…smallMoleculeFragmentAdducts member, which caused UI problems when that was the only value being edited (would not save)
|
@brendanx67 - shall I backport to release branch? |
|
Sure. Seems pretty safe and only of benefit. |
brendanx67
approved these changes
Oct 8, 2024
bspratt
added
the
Cherry pick to release
bspratt
deleted the
Skyline/work/20241007_missing_comparison_small_mol_fragment_filters
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…, which caused UI problems when that was the only value being edited (would not save)