From 4fb74ae1ce0ecb2c8b0b4c477ab13a4e178fe7e2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Dezs=C5=91=20BICZ=C3=93?= Date: Mon, 2 May 2022 16:40:59 +0200 Subject: [PATCH] Lock mglaman/drupal-check on <=1.2.1 Because newer versions produces malformed JSON output and run PHPStan on level 2 that causes extra overhead on downstream projects without PHPStan's baseline feature available. See: https://github.com/mglaman/drupal-check/issues/274 and https://mglaman.dev/blog/drupal-check-140-enforcing-phpstan-level-2 Issue-Link: https://project.pronovix.net/issues/17233 (cherry picked from commit 20927cff7eb356ec6b81f51838fbd7078459c027) Change-Id: I75d4faf6ad7e1e1c0c66288ace02677b7faf127b --- composer.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/composer.json b/composer.json index 51f04bf..cdf4bd9 100644 --- a/composer.json +++ b/composer.json @@ -13,7 +13,7 @@ ], "_comment": [ "composer/composer is not a dev requirement because this library depends on code from that", - "drupal/core-dev is here but the dependent package also must also require it otherwise it could happen that incorrect/unmatching versions gets installed with drupal/core and drupal/core-recommended" + "mglaman/drupal-check is locked on <=1.2.1 because newer versions produces malformed JSON output and run PHPStan on level 2. See: https://github.com/mglaman/drupal-check/issues/274 and https://mglaman.dev/blog/drupal-check-140-enforcing-phpstan-level-2" ], "require": { "php": "^7.4.0", @@ -28,7 +28,7 @@ "ergebnis/composer-normalize": "^2.13.0", "friendsoftwig/twigcs": "^3.1", "instaclick/php-webdriver": "^1.4.5", - "mglaman/drupal-check": "^1.2", + "mglaman/drupal-check": "<=1.2.1", "phpspec/prophecy-phpunit": "^2", "phpstan/phpstan": "^1.2", "pronovix/composer-logger": "^3.0",