Skip to content

Commit

Permalink
Avoid BC in Adapter and RegistryInterface for sorting metrics (#118)
Browse files Browse the repository at this point in the history
Signed-off-by: Javier Espinosa <[email protected]>
Signed-off-by: Javier Espinosa <[email protected]>
  • Loading branch information
javespi authored Apr 24, 2023
1 parent dce4295 commit 9b4850a
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion src/Prometheus/RegistryInterface.php
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ public function wipeStorage(): void;
/**
* @return MetricFamilySamples[]
*/
public function getMetricFamilySamples(bool $sortMetrics = true): array;
public function getMetricFamilySamples(): array;

/**
* @param string $namespace e.g. cms
Expand Down
2 changes: 1 addition & 1 deletion src/Prometheus/Storage/Adapter.php
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ interface Adapter
/**
* @return MetricFamilySamples[]
*/
public function collect(bool $sortMetrics = true): array;
public function collect(): array;

/**
* @param mixed[] $data
Expand Down

0 comments on commit 9b4850a

Please sign in to comment.