-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Github Action Super-Linter #2423
Comments
I was thinking that we could use super-linter to help with code reviews and maybe catch some style errors before @misaugstad, or whoever is doing the code review, looks at it. When you push to github, a Github Action will spin up for super-linter and run a linter to check the settings in We currently have the capability to lint code locally. However, I thought this would be worthwhile to implement to catch linting errors as they are pushed github and if it does not take too much extra time to set up. The linter uses the same rules as our linters for eslint, htmlhint and stylelint. So, the only thing we should have to change is the super-linter configuration settings, which I already put a little work into. You can also look at the "Actions" tab on the top to see the status of the tests. |
This is cool! We might want to include this, but not until I go through and lint the whole code base and fix the issues we already have 😁 Otherwise any time someone edits a file, this is going to fail because of all of the other errors in the file they edited. But I'd love to keep the PR open until we've done our first pass through! |
We could use github actions super-linter for continuous integration testing. https://github.com/github/super-linter
The text was updated successfully, but these errors were encountered: