Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

For the Lookup Bic action it makes more sense to set the passthrough as a configuration item. #70

Open
ErikHommel opened this issue Nov 16, 2023 · 2 comments
Open

For the Lookup Bic action it makes more sense to set the passthrough as a configuration item. #70

ErikHommel opened this issue Nov 16, 2023 · 2 comments
Labels
enhancement

Comments

@ErikHommel
Copy link
Contributor

ErikHommel commented Nov 16, 2023 •
edited
Loading

At the moment the passthroug (default to be used if no BIC found) is a parameter, which means you either have to pass the value as a parameter to the Form Processor using the action or use a Set Value action before the lookup. IMO it would be better to have a string as a configuration item so you can add a default value OR use a parameter?
@ErikHommel
Copy link
Contributor Author

I will provide a PR

@ErikHommel ErikHommel changed the title For the Lookup Bic action it makes more sense to set the passthrought as a configuration item. For the Lookup Bic action it makes more sense to set the passthrough as a configuration item. Nov 16, 2023
@bjendres bjendres added this to the 1.9 milestone Jan 30, 2024
@bjendres
Copy link
Member

@ErikHommel I'm assuming this isn't happening any more, right?

@bjendres bjendres removed this from the 1.9 milestone Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ErikHommel @bjendres