Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recompute welch timestamp , taking middle instead of start of spectro_duration or tuiles #208

Open
cazaudo opened this issue Oct 11, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@cazaudo
Copy link
Member

cazaudo commented Oct 11, 2024

in https://github.com/Project-OSmOSE/OSEkit/blob/main/src/OSmOSE/Spectrogram.py , we need to revise the definiton of list_timestamps , currently defined as

            list_timestamps.append(
                current_timestamp + timedelta(seconds=int(start))
            )

should be defined as the middle value of the wav (or the tuile if self.zoom_level>0) time boundaries

@cazaudo cazaudo added the bug Something isn't working label Oct 11, 2024
@Gautzilla
Copy link
Contributor

I didn't see this issue, sorry!

If i'm not mistaken, it just centers the time values on the tuiles instead of marking their start?

image

We have the tile_duration in this scope, and thus could use it directly?

        for tile in range(nber_tiles_lowest_zoom_level):
            start = tile * tile_duration
            end = start + tile_duration

            if not adjust:
                list_timestamps.append(
                    current_timestamp + timedelta(seconds=int(start + tile_duration//2)),
                )
            )

I've not tested it yet, that just to clarify that I understand correctly the issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants