Writing tests

[pavolo99]

Hi,
I would like to write some tests for my function, but the existing tests are without test data.
I don't think the tests are written effectively, because the test returns and checks the created list of books after mocking (see picture).

How should I proceed then?
Thanks for your answer.

[knjk04]

Hi @pavolo99,

If you haven't already, could you push this to a remote branch? Then, could you share a link to the branch? I can then clone this and take a look locally. Thanks

[pavolo99]

@knjk04, I have a problem with pushing branch because of insufficient access rights.
Is there any problem on my side or you have to assign me the pushing rights?
Thanks.

[knjk04]

@pavolo99 Am I right in saying that you're trying to push to this repository rather than your fork? If so, you'll need to fork the repository and then push to your fork.

See our contributing guidelines for the workflow

[pavolo99]

Im so sorry, I did not make a fork.

[pavolo99]

Here is link to branch: feature/769_predefined_shelf_controller

[knjk04]

Thanks for the link.

but the existing tests are without test data

Sorry, what do you mean by this? I thought the test data was the list of books that we're passing to the mocked call of the book service's findAll() method?