Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code is included in the scan results (as "excerpt") #47

Open
pandurangpatil opened this issue Sep 1, 2022 · 1 comment
Open

Code is included in the scan results (as "excerpt") #47

pandurangpatil opened this issue Sep 1, 2022 · 1 comment
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@pandurangpatil
Copy link
Member

Is your feature request related to a problem? Please describe.
Code is included in the scan results (as "excerpt") which is used to provide context for the finding. If someone chooses to use the Privacy View Cloud Dashboard, that code is uploaded to your cloud. I believe people will notice this and some will likely have a problem with it, especially since the github states ”Note that no code is sent to the cloud.”

Describe the solution you'd like
I suggest updating the language or asking the user if they want the code snippet to be included in the upload.

@pandurangpatil pandurangpatil added the enhancement New feature or request label Sep 1, 2022
@gnittala
Copy link

If the enhancement is being implemented, then can the documentation be changed now to state - 'By default no code is sent to the cloud, but the user can choose to send code snippets to the cloud'.
It will help if the excerpt has

  • Path to the file, filename
  • Line number
  • Last author (not sure about this one)

Also, it will help to consider if sending snippets to cloud can be an administrator level setting in the future - all-repos, specific repos, or only repos other than these etc.

@ojaswa1942 ojaswa1942 added the documentation Improvements or additions to documentation label Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants