Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StandardButtons ignore selected language #2833

Closed
1 task done
Kationor opened this issue Sep 17, 2024 · 0 comments · Fixed by #2837 · May be fixed by PrismLauncher/Translations#19
Closed
1 task done

StandardButtons ignore selected language #2833

Kationor opened this issue Sep 17, 2024 · 0 comments · Fixed by #2837 · May be fixed by PrismLauncher/Translations#19
Labels
bug Something isn't working

Comments

@Kationor
Copy link
Contributor

Operating System

Windows

Version of Prism Launcher

Prism Launcher 8.4, develop at dc67807

Version of Qt

Qt 6.7.1 (stable), Qt 6.7.2 (develop)

Description of bug

When selecting a different language, the standard buttons provided by Qt should also be translated. This is not the case.

GPUyBxM4R7ZA7mTd

Steps to reproduce

  • Change Prism's language to something other than English
  • Observe that the StandardButtons do not get translated appropriately

Suspected cause

These translation files are not present.

PrismLauncher/launcher/translations/TranslationsModel.cpp

Lines 481 to 490 in dc67807

// FIXME: this is likely never present. FIX IT.
d->m_qt_translator.reset(new QTranslator());
if (d->m_qt_translator->load("qt_" + langCode, QLibraryInfo::location(QLibraryInfo::TranslationsPath))) {
qDebug() << "Loading Qt Language File for" << langCode.toLocal8Bit().constData() << "...";
if (!QCoreApplication::installTranslator(d->m_qt_translator.get())) {
qCritical() << "Loading Qt Language File failed.";
d->m_qt_translator.reset();
} else {
successful = true;
}

(Code itself works, tested by manually placing the appropriate files there.)

This issue is unique

  • I have searched the issue tracker and did not find an issue describing my bug.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
1 participant
@Kationor