Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a drop shadow to the contextual notes on tablet/desktop #87

Open
gissoo opened this issue Jun 16, 2020 · 6 comments
Open

Add a drop shadow to the contextual notes on tablet/desktop #87

gissoo opened this issue Jun 16, 2020 · 6 comments
Labels
enhancement New feature or request

Comments

@gissoo
Copy link
Contributor

gissoo commented Jun 16, 2020

@thatbudakguy thatbudakguy added the enhancement New feature or request label Jun 17, 2020
@thatbudakguy thatbudakguy added this to the Issue 1 milestone Sep 24, 2020
Copy link
Collaborator

thatbudakguy commented Sep 29, 2020

<@rlskoeser> we put it off because it was hard. You can't put a css drop shadow on an absolutely positioned div. I tried a few different things. What I remember as possibilities to try next: move the shape that's visible into an inner container that could have a drop shadow (this will require recalculating sizes and positions) or try using a background image for the shadow. I don't know if the background image would be visible / allowed to extend into padding (which I think you'd have to add, but not as hard as the other option, this is one of the things I tried when still trying to get drop shadow to work).
View in Slack

@thatbudakguy thatbudakguy removed their assignment Oct 1, 2020
@thatbudakguy thatbudakguy removed this from the Issue 1 milestone Oct 1, 2020
@rlskoeser
Copy link
Contributor

rlskoeser commented Oct 23, 2020

@gissoo noting because I had a tab open about using borders to simulate drop shadows. I couldn't get the example to work with our styles, but wondered if a border with an image would work to solve this?

Here's what the contextual notes look like with just a simple gray border on bottom and right edges:
Screen Shot 2020-10-23 at 6 03 41 PM

I haven't used border images before so I don't know how we need to set them up, but might work here.

@thatbudakguy
Copy link
Collaborator

a border with an image

can you expand on this? is the screenshot you posted using an actual image laid underneath the contextual note, or just a css border (or some combination)? the example you posted looks pretty useful, especially if we use a transparent border. i think even just having it on the bottom would help somewhat.

@rlskoeser
Copy link
Contributor

This image is just a straight up css border on bottom and right — I used gray, forget how many pixels (5ish?). I agree, I think this might be better than nothing - especially for the one contextual note in DBV that comes right before the interlude, where you end up with a purple note over a purple background.

I'm not sure how well transparent works, it might be transparent over the other color (i.e. purple).

IDK if border image would work here or not. Here's an example https://developer.mozilla.org/en-US/docs/Web/CSS/border-image

@thatbudakguy
Copy link
Collaborator

whoa, had no idea about border-image. i think if we can, a regular border is the way to go. I'll see if I can mock up something and test how transparency works out.

@rlskoeser
Copy link
Contributor

rlskoeser commented Oct 27, 2020

@gissoo would a simple gray border (see screenshot above) be better than nothing?

(never mind! no last minute changes, too easy to introduce errors! 😬 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants