Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add focus shifting when activating contextual notes #169

Open
thatbudakguy opened this issue Nov 2, 2020 · 0 comments
Open

add focus shifting when activating contextual notes #169

thatbudakguy opened this issue Nov 2, 2020 · 0 comments
Labels
♿ accessibility Impacts access for some users

Comments

@thatbudakguy
Copy link
Collaborator

the main concern from John Jameson's accessibility review is the accessibility of contextual notes for SRs/keyboard users:

This tooltip is suuuuuper janky on keyboards and doesn’t work at all on screen readers, because the actual content is somewhere else on the page. If it’s going to be inline, make it inline in the DOM too (so the text appears in context for assistive devices — Tippy is great for this ). If it needs to be at the end of the DOM, take over and trap the cursor in a modal dialog. I can be more verbose on this if you want :-D

we're the latter case (the content needs to be at the end of the DOM, since that's where it gets rendered as an endnote), so we need to implement some automatic focus shifting so that the content of contextual notes is automatically focused when the note is activated.

JJ hints at the contextual note behaving like a modal, which is interesting - maybe we will also need to apply/remove some ARIA so that the SR user knows that when the note is active, they need to close it to continue reading.

@thatbudakguy thatbudakguy added the ♿ accessibility Impacts access for some users label Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
♿ accessibility Impacts access for some users
Projects
None yet
Development

No branches or pull requests

1 participant