Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As an admin, I want to control the placement of profiles based on the positions held by people so I can make sure they show up on the right listing page. #232

Open
thatbudakguy opened this issue Nov 5, 2020 · 1 comment

Comments

@thatbudakguy
Copy link
Contributor

Is your feature request related to a problem? Please describe.
There's a current conflict in the logic that aggregates profiles between relying on information on a person's "princeton status" (which is initially populated from Princeton's own directory system but can later be changed) and information coming from the positions they've held at CDH or on a CDH-sponsored grant. This leads to inconsistencies in which profiles are displayed on which listing pages.

Describe the solution you'd like
The sole determinant of which page a profile appears on should be the position a person held in their relationship to CDH. We currently hard-code these values into lists like postdoc_titles and student_titles, but they should be able to be set in the admin interface as part of the data of either the title itself, or the particular position instance (person + title + dates). If people have no relationship to CDH through a position (only through a grant), perhaps we can localize such profiles to the Affiliates page, since that page should list all people who have received grants from CDH (including students, though it doesn't currently).

Additional context
For an example of currently hard-coded position -> status mappings, see:

#: position titles that indicate a person is a postdoc
postdoc_title = 'Postdoctoral Fellow'
#: variant postdoc title for Princeton PGRA
postgrad_title = 'Postgraduate Research Associate'
#: position titles that indicate a person is a project director
director_roles = ['Project Director', 'Co-PI: Research Lead']
#: position titles that indicate a staff person is a student
student_titles = ['Graduate Fellow', 'Graduate Assistant',
'Undergraduate Assistant']
#: memebership roles that indicate someone is an affiliate
project_roles = ['Project Director',
'Project Manager', 'Co-PI: Research Lead']
#: student status codes from LDAP
student_pu_status = ['graduate', 'undergraduate']
#: executive committee member titles
exec_member_title = 'Executive Committee Member'
with_exec_title = 'Sits with Executive Committee'
exec_committee_titles = [exec_member_title, with_exec_title]

@thatbudakguy thatbudakguy added this to the v3.2 milestone Jun 10, 2021
@thatbudakguy thatbudakguy removed this from the v3.4 milestone Aug 9, 2021
@rlskoeser
Copy link
Contributor

notes from discussion with @thatbudakguy for more details on his idea to solve this:

  • titles would have configurable many-to-many relation to person list; e.g. faculty director & interim faculty director title would be staff and exec
  • anyone without a cdh position and thus no title (i.e., only related via grant as project director) goes onto the affiliate page; currently we exclude students from that page, but we don't want to do that in future; so maybe grant roles could have a similar functionality to cdh titles. Student project managers with no other cdh staff could work the same way — use the relationship between role and person list to put them on the students page

@thatbudakguy thatbudakguy changed the title As an admin, I want to control the student/staff status of profiles based on the positions held by people so I can make sure they show up on the right listing page. As an admin, I want to control the placement of profiles based on the positions held by people so I can make sure they show up on the right listing page. Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants