chore: Update to v2 NEX libraries #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have confirmed this works just as much as it did on the current server where you can upload mission scores, but BOSS ranking doesn't work yet. I'm grabbing a 100% save to test the rest of the functionality. |
|
Can't seem to figure it out: besides the game rankings are done via BOSS. The main purpose of the server is just to upload the scores in missions to my knowledge, so it works. |
ItzSwirlz
changed the title
|
Code looks fine to my eyes, though I don't have this game to test right now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2
Changes:
Updated to nex-go v2 and equivalent NEX libraries
Uses common ranking protocol
Renamed method and file
GetRankingsByCategoryAndRankingOrderParamto proper full nameGetRankingsAndCountByCategoryAndRankingOrderParamUpdated database functions to work with the v2 ranking protocol
I have read and agreed to the Code of Conduct.
I have read and complied with the contributing guidelines.
What I'm implementing was an approved issue.
I have tested all of my changes.