From 6393629aa0f013c127ffcd728d86ccccf911f2d4 Mon Sep 17 00:00:00 2001 From: Francesco Rizzi Date: Mon, 24 May 2021 20:32:08 +0200 Subject: [PATCH] add comment to clarify things --- include/impl/advection1d/eigen_linear.hpp | 4 ++++ include/impl/euler1d/eigen_app.hpp | 5 +++++ include/impl/euler2d/eigen_app.hpp | 4 ++++ 3 files changed, 13 insertions(+) diff --git a/include/impl/advection1d/eigen_linear.hpp b/include/impl/advection1d/eigen_linear.hpp index a569ed20..d3b13e12 100644 --- a/include/impl/advection1d/eigen_linear.hpp +++ b/include/impl/advection1d/eigen_linear.hpp @@ -2,6 +2,10 @@ #ifndef PRESSIODEMOAPPS_LINEAR_ADVECTION_1D_HPP_ #define PRESSIODEMOAPPS_LINEAR_ADVECTION_1D_HPP_ +// note that the code below is pretty ugly for now, but it works. +// this is inside impl namespace for a reason, and will need to be +// improved later on but we have a starting point. + namespace pressiodemoapps{ namespace ad{ namespace impl{ template diff --git a/include/impl/euler1d/eigen_app.hpp b/include/impl/euler1d/eigen_app.hpp index ffef615c..904773e2 100644 --- a/include/impl/euler1d/eigen_app.hpp +++ b/include/impl/euler1d/eigen_app.hpp @@ -2,6 +2,11 @@ #ifndef PRESSIODEMOAPPS_EULER1D_APP_HPP_ #define PRESSIODEMOAPPS_EULER1D_APP_HPP_ +// note that the code below is pretty ugly for now, but it works. +// this is inside impl namespace for a reason, and will need to be +// improved later on but we have a starting point. + + /* probid = 1 (Sod) taken from: https://www.mdpi.com/2227-7390/6/10/211/pdf */ diff --git a/include/impl/euler2d/eigen_app.hpp b/include/impl/euler2d/eigen_app.hpp index 5d05612f..f8db325b 100644 --- a/include/impl/euler2d/eigen_app.hpp +++ b/include/impl/euler2d/eigen_app.hpp @@ -2,6 +2,10 @@ #ifndef PRESSIODEMOAPPS_EULER2D_HPP_ #define PRESSIODEMOAPPS_EULER2D_HPP_ +// note that the code below is pretty ugly for now, but it works. +// this is inside impl namespace for a reason, and will need to be +// improved later on but we have a starting point. + /* problemId = 0: generic problem with periodic BC so ghosts are not used problemId = 1: Sedov