Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ssh-agent present in .gitignore #2258

Open
3 tasks done
LexaPrime opened this issue Jul 25, 2024 · 1 comment
Open
3 tasks done

ssh-agent present in .gitignore #2258

LexaPrime opened this issue Jul 25, 2024 · 1 comment
Labels
Area-Build Waiting on Author Need more information to diagnose

Comments

@LexaPrime
Copy link

Prerequisites

  • Write a descriptive title.
  • Make sure you are able to repro it on the latest version
  • Search the existing issues.

Steps to reproduce

.gitignore contains ssh-agent in line 28, which ignores contrib/win32/win32compat/ssh-agent/. That folder is included in the repository, and necessary to build ssh-agent.vcxproj. Was this intended?

Expected behavior

All projects are built correctly.

Actual behavior

When pushing the repository to a different remote, `contrib/win32/win32compat/ssh-agent/` is ignored. Building the solution after cloning from such remote results in several C1083 errors, for example:
`C1083 Cannot open source file: '(...)\contrib\win32\win32compat\ssh-agent\agent-main.c': No such file or directory`

Error details

No response

Environment data

N/A

Version

latestw_all

Visuals

No response

@tgauth tgauth transferred this issue from PowerShell/openssh-portable Jul 29, 2024
@tgauth
Copy link
Collaborator

tgauth commented Jul 29, 2024

Line 28 in the .gitignore is from upstream - it is to prevent pushing the built ssh-agent binary to the repo.
It should not prevent cloning agent-main.c from this repo - https://github.com/PowerShell/openssh-portable/blob/latestw_all/contrib/win32/win32compat/ssh-agent/agent-main.c

If you still have issues building the project, please provide more details about the scenario.

@tgauth tgauth added Area-Build Waiting on Author Need more information to diagnose labels Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Build Waiting on Author Need more information to diagnose
Projects
None yet
Development

No branches or pull requests

2 participants