-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable in-database configuration for pool settings #3110
Comments
Isn't this what signal based config reloading is meant for? Adding config settings which could potentially break the database connection when changed to wrong values to in-db configuration... is something that I would like to avoid, because you can't recover from it via database anymore. |
I get the point, that's why
The above seem completely safe to me in that regard.
Would a large Now a negative or 0 |
Maybe if it surpasses |
Problem
Currently the following settings have no in-db option:
So whenever they need to be updated the
postgrest.service
(if using systemd) has to be restarted. During this lapse Nginx (or other proxy) will give uninformative error messages likeAn invalid response was received from the upstream server
.Solution
Enable in-db options for the above configs. While there will be some downtime during the pool restart, we can give a better error message and include a
Retry-After
header.The text was updated successfully, but these errors were encountered: