chore: create issue fingerprint table in postgres #25690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daibhin
commented
Oct 18, 2024
| class ErrorTrackingIssueFingerprint(models.Model): | ||
| team = models.ForeignKey("Team", on_delete=models.CASCADE, db_index=False) | ||
| issue = models.ForeignKey(ErrorTrackingGroup, on_delete=models.CASCADE) | ||
| fingerprint = models.CharField(max_length=400) |
There was a problem hiding this comment.
Going with a string here. I know fingerprints are arrays of strings right now but I feel like the intention is to move towards a proper hash that will be stored as a string
There was a problem hiding this comment.
I think that's correct, yeah.... although I don't know that setting a 400 character limit on it is a good idea. We want a postgres TEXT field here I think (unless this is a constraint coming from clickhouse?)
There was a problem hiding this comment.
400 is a "magic number" dotted around our codebase whose significance I don't understand.
tkaemming
reviewed
Oct 18, 2024
oliverb123
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Related to Related to https://github.com/PostHog/product-internal/pull/662
Changes
Adds a new Postgres table that tracks any issue fingerprint overrides. This is the source of truth from which the ClickHouse table is based.