feat: add api_token to livestream jwt claims #23082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this will allow us to drop the postgres dependency soon
frankh
force-pushed
the
frank/livestream-api-claim
branch
from
51f91ce to
93a326f
Compare
fuziontech
approved these changes
Jun 19, 2024
| @@ -199,7 +199,7 @@ def get_groups_on_events_querying_enabled(self, team: Team) -> bool: | |||
|
|
|||
| def get_live_events_token(self, team: Team) -> Optional[str]: | |||
| return encode_jwt( | |||
| {"team_id": team.id}, | |||
| {"team_id": team.id, "api_token": team.api_token}, | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
currently livestream has a dependency on postgres, but this is literally only used to fetch the api_token for a team.
include the token with jwt claim so we can kill this dependency
also:
Changes
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
How did you test this code?