Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add two new metrics for blobby commits #19818

Merged
merged 2 commits into from
Jan 18, 2024
Merged

chore: add two new metrics for blobby commits #19818

merged 2 commits into from
Jan 18, 2024

Conversation

pauldambra
Copy link
Member

We're fast approaching a counter per if condition in the blobby code base 🙈

This adds two new metrics

  1. a count every time we can't commit to kafka because of a potentially blocking session
  2. a histogram of the number of active sessions on the blocked partition when it is blocked

@pauldambra pauldambra merged commit b707cf5 into master Jan 18, 2024
92 checks passed
@pauldambra pauldambra deleted the chore/add-two-new-metrics branch January 18, 2024 08:38
@pauldambra
Copy link
Member Author

🤔 @benjackwhite neither of these metrics have anything in victoria metrics 🤯

I did something silly?

@tiina303
Copy link
Contributor

maybe we never reach that code 🤷‍♀️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiina303 tiina303 tiina303 approved these changes

@benjackwhite benjackwhite Awaiting requested review from benjackwhite

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pauldambra @tiina303