Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check if future exists before grabbing it #17562

Merged
merged 1 commit into from
Sep 20, 2023
Merged

fix: check if future exists before grabbing it #17562

merged 1 commit into from
Sep 20, 2023

Conversation

fuziontech
Copy link
Member

Problem

Changes

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

How did you test this code?

@posthog-bot
Copy link
Contributor

Hey @fuziontech! 👋
This pull request seems to contain no description. Please add useful context, rationale, and/or any other information that will help make sense of this change now and in the distant Mars-based future.

@frankh frankh merged commit 94a7bc9 into master Sep 20, 2023
@frankh frankh deleted the if_none branch September 20, 2023 21:51
fuziontech added a commit that referenced this pull request Sep 20, 2023
fuziontech added a commit that referenced this pull request Sep 20, 2023
Revert "fix: check if future exists before grabbing it (#17562)"

This reverts commit 94a7bc9.
daibhin pushed a commit that referenced this pull request Sep 21, 2023
Revert "fix: check if future exists before grabbing it (#17562)"

This reverts commit 94a7bc9.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants