{widgets.map(({ key, label, Component }) => (
-
setWidgetsVisible(false)}>
+
diff --git a/frontend/src/scenes/notebooks/Notebook/notebookLogic.ts b/frontend/src/scenes/notebooks/Notebook/notebookLogic.ts
index a19b5f09dd1c5..68cb94dbc3265 100644
--- a/frontend/src/scenes/notebooks/Notebook/notebookLogic.ts
+++ b/frontend/src/scenes/notebooks/Notebook/notebookLogic.ts
@@ -77,6 +77,7 @@ export const notebookLogic = kea([
exportJSON: true,
showConflictWarning: true,
onUpdateEditor: true,
+ setIsShowingSidebar: (showing: boolean) => ({ showing }),
registerNodeLogic: (nodeLogic: BuiltLogic) => ({ nodeLogic }),
unregisterNodeLogic: (nodeLogic: BuiltLogic) => ({ nodeLogic }),
setEditable: (editable: boolean) => ({ editable }),
@@ -166,6 +167,13 @@ export const notebookLogic = kea([
setEditable: (_, { editable }) => editable,
},
],
+ isShowingSidebar: [
+ false,
+ {
+ setSelectedNodeId: (showing, { selectedNodeId }) => (selectedNodeId ? showing : false),
+ setIsShowingSidebar: (_, { showing }) => showing,
+ },
+ ],
}),
loaders(({ values, props, actions }) => ({
notebook: [
@@ -334,10 +342,6 @@ export const notebookLogic = kea([
}
},
],
- isShowingSidebar: [
- (s) => [s.selectedNodeLogic],
- (selectedNodeLogic) => selectedNodeLogic?.values.isShowingWidgets,
- ],
}),
sharedListeners(({ values, actions }) => ({
onNotebookChange: () => {
diff --git a/frontend/src/scenes/notebooks/Notebook/utils.ts b/frontend/src/scenes/notebooks/Notebook/utils.ts
index 44feef88726e0..ed78f61d20f89 100644
--- a/frontend/src/scenes/notebooks/Notebook/utils.ts
+++ b/frontend/src/scenes/notebooks/Notebook/utils.ts
@@ -48,7 +48,6 @@ export type NotebookNodeViewProps = Omit
export type NotebookNodeWidget = {
key: string
label: string
- icon: JSX.Element
// using 'any' here shouldn't be necessary but, I couldn't figure out how to set a generic on the notebookNodeLogic props
Component: ({ attributes, updateAttributes }: NotebookNodeAttributeProperties) => JSX.Element
}
diff --git a/playwright/e2e-vrt/layout/Navigation.spec.ts-snapshots/Navigation-App-Page-With-Side-Bar-Hidden-Mobile-1-chromium-linux.png b/playwright/e2e-vrt/layout/Navigation.spec.ts-snapshots/Navigation-App-Page-With-Side-Bar-Hidden-Mobile-1-chromium-linux.png
index 24af8b2279910..8b8203a70dcf5 100644
Binary files a/playwright/e2e-vrt/layout/Navigation.spec.ts-snapshots/Navigation-App-Page-With-Side-Bar-Hidden-Mobile-1-chromium-linux.png and b/playwright/e2e-vrt/layout/Navigation.spec.ts-snapshots/Navigation-App-Page-With-Side-Bar-Hidden-Mobile-1-chromium-linux.png differ
diff --git a/playwright/e2e-vrt/layout/Navigation.spec.ts-snapshots/Navigation-App-Page-With-Side-Bar-Shown-Mobile-1-chromium-linux.png b/playwright/e2e-vrt/layout/Navigation.spec.ts-snapshots/Navigation-App-Page-With-Side-Bar-Shown-Mobile-1-chromium-linux.png
index 24af8b2279910..8b8203a70dcf5 100644
Binary files a/playwright/e2e-vrt/layout/Navigation.spec.ts-snapshots/Navigation-App-Page-With-Side-Bar-Shown-Mobile-1-chromium-linux.png and b/playwright/e2e-vrt/layout/Navigation.spec.ts-snapshots/Navigation-App-Page-With-Side-Bar-Shown-Mobile-1-chromium-linux.png differ