Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Show console logs and network perf toggled ON by default #18749

Closed
corywatilo opened this issue Nov 20, 2023 · 1 comment · Fixed by #23900
Closed

Chore: Show console logs and network perf toggled ON by default #18749

corywatilo opened this issue Nov 20, 2023 · 1 comment · Fixed by #23900
Labels
feature/replay Features for Team Replay

Comments

@corywatilo
Copy link
Contributor

(Super tiny nit but...)

When toggling on session recording, it also toggles on console logs and network performance. (This makes sense, as you should be opted in to the full suite by default rather than forcing users to manually enable.)

Given this, the default state for the console logs and perf buttons should be enabled (and grayed out). This way, only the thing you're toggling (enabling record user sessions) is changing when you click it, and you can already expect to get the subsequent featured that are already toggled on.

2023-11-20 07 39 44

@namit-chandwani
Copy link
Contributor

Hi @corywatilo @pauldambra @marandaneto, I've created a PR which can close this issue.
Have tested the changes locally and included a screen recording of the same in the PR description for reference.

Request you to review the PR whenever free

TIA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/replay Features for Team Replay
3 participants