Insights in Notebooks Issues

[thmsobrmlr]

Bug description

Three major flows need to work:

• Editing an insight in a notebook while not on the insights page (and possibly never having been there). This is to make sure all required logics get mounted independently.
• Editing an insight in a notebook while on the insights page for the respective insight type. This is to make sure the logics aren't accidentally connected.
• Editing an insight in a standalone notebook.

Issues seem to originated from these general areas:

• insightVizDataLogic is wrapped
• logics are not uniquely keyed
• chartjs isn't updated due to its imperative api
• style conflicts
• ux issues

---

• Test all insight options (test on respective insight page)
  • Trends
  • Funnels
  • Retention
  • Path
  • Stickiness
  • Lifecycle
  • SQL
  • Custom

General

• How to go from one insight type to another?
• Changing a funnel on /insights/new with funnel, changes both... fix(notebooks): use varying keys for action filters #18591
• key breakdown differently fix(notebooks): use varying keys for breakdown filter #18596
• key global insight filters differently fix(notebooks): use varying keys for global filters #18601
• key sampling filter differently fix(notebooks): use varying keys for sampling filter #18603
• Changing graph type is broken fix(notebooks): convert funnel type to lemon ui #18593
  
  src="https://github.com/PostHog/posthog/assets/1851359/81967f46-ebd0-49b7-82bd-0eddec721b97">
• Where is insightVizDataLogic wrapped? -> potentially unwrap (test NOT on insight page)
• Insights can't be dragged to the notebooks (pasting logic?)

Trends

• Fix displaying hover info on trend line
• Fix displaying legend

Funnels

• Breakdown does not make sense, as breakdowns are displayed only in the table
• Editing funnel series doesn't work fix(notebooks): move funnel series and exclusion selectors #18613
• Info for funnel doesn't work
  
• Styling of InsightDisplayConfig for funnels
  <img width="783" alt="Screenshot 2023-11-13 at 17 28 15"
• ProseMirror styles conflict with LemonInput .ProseMirror-hideselection *::selection
  
• FunnelStepsPicker doesn't work as it connects to component notebooks node (instead of settings which can update attributes) fix(notebooks): handle updates in insight visualization component #18641
• Historical Trends doesn't display interval

Paths

• Path Exclusions connects to insight fix(notebooks): use varying keys for path and retention filters #18639
• Path steps dropdown is cutoff -> replace with lemon UI
  https://posthog.slack.com/archives/C05N9R3HT7V/p1699969718742449 feat(3000): replace step picker with lemon ui #18870
• Steps builder
  https://posthog.slack.com/archives/C05N9R3HT7V/p1699970114717249

Retention

• Came back event connects to picker on insight page fix(notebooks): use varying keys for path and retention filters #18639

Stickiness

•  Toggling between line and bar doesn't trigger update

Lifecycle

• Toggling lifecycles doesn't work