diff --git a/frontend/src/lib/constants.tsx b/frontend/src/lib/constants.tsx index 522d393f0f9a6c..32e01e39f63220 100644 --- a/frontend/src/lib/constants.tsx +++ b/frontend/src/lib/constants.tsx @@ -191,7 +191,6 @@ export const FEATURE_FLAGS = { YEAR_IN_HOG: 'year-in-hog', // owner: #team-replay SESSION_REPLAY_EXPORT_MOBILE_DATA: 'session-replay-export-mobile-data', // owner: #team-replay DISCUSSIONS: 'discussions', // owner: #team-replay - REDIRECT_INSIGHT_CREATION_PRODUCT_ANALYTICS_ONBOARDING: 'redirect-insight-creation-product-analytics-onboarding', // owner: @biancayang SIDEPANEL_STATUS: 'sidepanel-status', // owner: @benjackwhite NEW_FEATURE_FLAG_OPERATORS: 'new-feature-flag-operators', // owner: @neilkakkar AI_SESSION_SUMMARY: 'ai-session-summary', // owner: #team-replay diff --git a/frontend/src/scenes/onboarding/onboardingLogic.tsx b/frontend/src/scenes/onboarding/onboardingLogic.tsx index f6b597b74414a3..8857c73b7fe428 100644 --- a/frontend/src/scenes/onboarding/onboardingLogic.tsx +++ b/frontend/src/scenes/onboarding/onboardingLogic.tsx @@ -1,7 +1,6 @@ import { actions, connect, kea, listeners, path, props, reducers, selectors } from 'kea' -import { actionToUrl, combineUrl, router, urlToAction } from 'kea-router' -import { FEATURE_FLAGS } from 'lib/constants' -import { featureFlagLogic, FeatureFlagsSet } from 'lib/logic/featureFlagLogic' +import { actionToUrl, router, urlToAction } from 'kea-router' +import { featureFlagLogic } from 'lib/logic/featureFlagLogic' import { eventUsageLogic } from 'lib/utils/eventUsageLogic' import { billingLogic } from 'scenes/billing/billingLogic' import { preflightLogic } from 'scenes/PreflightCheck/preflightLogic' @@ -62,13 +61,10 @@ export const stepKeyToTitle = (stepKey?: OnboardingStepKey): undefined | string export type AllOnboardingSteps = OnboardingStep[] export type OnboardingStep = JSX.Element -export const getProductUri = (productKey: ProductKey, featureFlags?: FeatureFlagsSet): string => { +export const getProductUri = (productKey: ProductKey): string => { switch (productKey) { case ProductKey.PRODUCT_ANALYTICS: - return featureFlags && - featureFlags[FEATURE_FLAGS.REDIRECT_INSIGHT_CREATION_PRODUCT_ANALYTICS_ONBOARDING] === 'test' - ? urls.insightNew() - : combineUrl(urls.insights(), {}, { panel: 'activation' }).url + return urls.insightNew() case ProductKey.SESSION_REPLAY: return urls.replay() case ProductKey.FEATURE_FLAGS: @@ -168,9 +164,9 @@ export const onboardingLogic = kea([ }, ], onCompleteOnboardingRedirectUrl: [ - (s) => [s.featureFlags, s.productKey], - (featureFlags: FeatureFlagsSet, productKey: string | null) => { - return productKey ? getProductUri(productKey as ProductKey, featureFlags) : urls.default() + (s) => [s.productKey], + (productKey: string | null) => { + return productKey ? getProductUri(productKey as ProductKey) : urls.default() }, ], totalOnboardingSteps: [ diff --git a/frontend/src/scenes/products/Products.tsx b/frontend/src/scenes/products/Products.tsx index c1f7311425a057..0a37ab2c57b8eb 100644 --- a/frontend/src/scenes/products/Products.tsx +++ b/frontend/src/scenes/products/Products.tsx @@ -5,7 +5,6 @@ import { useActions, useValues } from 'kea' import { router } from 'kea-router' import { LemonCard } from 'lib/lemon-ui/LemonCard/LemonCard' import { Spinner } from 'lib/lemon-ui/Spinner' -import { featureFlagLogic } from 'lib/logic/featureFlagLogic' import { eventUsageLogic } from 'lib/utils/eventUsageLogic' import { billingLogic } from 'scenes/billing/billingLogic' import { getProductUri, onboardingLogic } from 'scenes/onboarding/onboardingLogic' @@ -44,7 +43,6 @@ export function ProductCard({ className?: string }): JSX.Element { const { currentTeam } = useValues(teamLogic) - const { featureFlags } = useValues(featureFlagLogic) const { setIncludeIntro } = useActions(onboardingLogic) const { user } = useValues(userLogic) const { reportOnboardingProductSelected } = useActions(eventUsageLogic) @@ -77,7 +75,7 @@ export function ProductCard({ className="relative" onClick={(e) => { e.stopPropagation() - router.actions.push(getProductUri(product.type as ProductKey, featureFlags)) + router.actions.push(getProductUri(product.type as ProductKey)) }} > diff --git a/posthog/batch_exports/models.py b/posthog/batch_exports/models.py index 35fa6e8ba47549..70b85c4d35bde7 100644 --- a/posthog/batch_exports/models.py +++ b/posthog/batch_exports/models.py @@ -306,5 +306,5 @@ class Status(models.TextChoices): def workflow_id(self) -> str: """Return the Workflow id that corresponds to this BatchExportBackfill model.""" start_at = self.start_at.strftime("%Y-%m-%dT%H:%M:%S") - end_at = self.end_at.strftime("%Y-%m-%dT%H:%M:%S") + end_at = self.end_at and self.end_at.strftime("%Y-%m-%dT%H:%M:%S") return f"{self.batch_export.id}-Backfill-{start_at}-{end_at}"