From f71530bfc8b813f0bf9968690248c4f5cb23ca07 Mon Sep 17 00:00:00 2001
From: Michael Matloka <dev@twixes.com>
Date: Fri, 24 Nov 2023 18:50:43 +0100
Subject: [PATCH] feat(experiments): Warn before leaving unsaved new experiment
 (#18894)

---
 .../src/scenes/experiments/Experiment.scss    |  1 +
 .../scenes/experiments/experimentLogic.tsx    | 20 +++++++++++++++----
 .../src/scenes/insights/insightSceneLogic.tsx |  1 +
 3 files changed, 18 insertions(+), 4 deletions(-)

diff --git a/frontend/src/scenes/experiments/Experiment.scss b/frontend/src/scenes/experiments/Experiment.scss
index d2039e10ec5a5..07b55c45051f8 100644
--- a/frontend/src/scenes/experiments/Experiment.scss
+++ b/frontend/src/scenes/experiments/Experiment.scss
@@ -176,6 +176,7 @@
 }
 
 .preview-conversion-goal-num {
+    flex-shrink: 0;
     width: 24px;
     height: 24px;
     margin-right: 0.5rem;
diff --git a/frontend/src/scenes/experiments/experimentLogic.tsx b/frontend/src/scenes/experiments/experimentLogic.tsx
index af0f013600fbd..356f0754803e0 100644
--- a/frontend/src/scenes/experiments/experimentLogic.tsx
+++ b/frontend/src/scenes/experiments/experimentLogic.tsx
@@ -1,7 +1,7 @@
 import { actions, connect, kea, key, listeners, path, props, reducers, selectors } from 'kea'
 import { forms } from 'kea-forms'
 import { loaders } from 'kea-loaders'
-import { router, urlToAction } from 'kea-router'
+import { beforeUnload, router, urlToAction } from 'kea-router'
 import api from 'lib/api'
 import { FunnelLayout } from 'lib/constants'
 import { dayjs } from 'lib/dayjs'
@@ -15,6 +15,7 @@ import { validateFeatureFlagKey } from 'scenes/feature-flags/featureFlagLogic'
 import { insightDataLogic } from 'scenes/insights/insightDataLogic'
 import { insightVizDataLogic } from 'scenes/insights/insightVizDataLogic'
 import { cleanFilters, getDefaultEvent } from 'scenes/insights/utils/cleanFilters'
+import { sceneLogic } from 'scenes/sceneLogic'
 import { Scene } from 'scenes/sceneTypes'
 import { teamLogic } from 'scenes/teamLogic'
 import { urls } from 'scenes/urls'
@@ -83,7 +84,14 @@ export const experimentLogic = kea<experimentLogicType>([
     key((props) => props.experimentId || 'new'),
     path((key) => ['scenes', 'experiment', 'experimentLogic', key]),
     connect(() => ({
-        values: [teamLogic, ['currentTeamId'], groupsModel, ['aggregationLabel', 'groupTypes', 'showGroupsOptions']],
+        values: [
+            teamLogic,
+            ['currentTeamId'],
+            groupsModel,
+            ['aggregationLabel', 'groupTypes', 'showGroupsOptions'],
+            sceneLogic,
+            ['activeScene'],
+        ],
         actions: [
             experimentsLogic,
             ['updateExperiments', 'addToExperiments'],
@@ -300,7 +308,7 @@ export const experimentLogic = kea<experimentLogicType>([
                     if (response?.id) {
                         actions.updateExperiments(response)
                         actions.setEditExperiment(false)
-                        actions.setExperiment(response)
+                        actions.loadExperimentSuccess(response)
                         return
                     }
                 } else {
@@ -381,7 +389,7 @@ export const experimentLogic = kea<experimentLogicType>([
 
             actions.updateExposureQuerySource(filtersToQueryNode(newInsightFilters))
         },
-        // // sync form value `filters` with query
+        // sync form value `filters` with query
         setExposureQuery: ({ query }) => {
             actions.setExperiment({
                 parameters: {
@@ -1017,6 +1025,10 @@ export const experimentLogic = kea<experimentLogicType>([
             }
         },
     })),
+    beforeUnload(({ values, props }) => ({
+        enabled: () => values.activeScene === Scene.Experiment && props.experimentId === 'new',
+        message: `Leave experiment?\nChanges you made will be discarded.`,
+    })),
 ])
 
 function percentageDistribution(variantCount: number): number[] {
diff --git a/frontend/src/scenes/insights/insightSceneLogic.tsx b/frontend/src/scenes/insights/insightSceneLogic.tsx
index eea9fe3ca0279..8a8f1fda9cd0e 100644
--- a/frontend/src/scenes/insights/insightSceneLogic.tsx
+++ b/frontend/src/scenes/insights/insightSceneLogic.tsx
@@ -245,6 +245,7 @@ export const insightSceneLogic = kea<insightSceneLogicType>([
             }
 
             if (values.isDev) {
+                // TRICKY: We disable beforeUnload handling in dev, but ONLY for insights
                 return false
             }