From ecb909281824d4fe9005c448fe113c6a24a03931 Mon Sep 17 00:00:00 2001
From: Ben White <ben@posthog.com>
Date: Fri, 20 Dec 2024 16:17:16 +0100
Subject: [PATCH] Fixes

---
 .../panels/activity/SidePanelActivitySubscriptions.tsx     | 1 +
 frontend/src/scenes/actions/ActionHogFunctions.tsx         | 1 +
 .../scenes/data-management/definition/DefinitionView.tsx   | 7 ++++---
 .../scenes/early-access-features/EarlyAccessFeature.tsx    | 1 +
 .../error-tracking/alerts/ErrorTrackingAlertsScene.tsx     | 5 +++--
 .../pipeline/hogfunctions/list/LinkedHogFunctions.tsx      | 3 +++
 .../pipeline/hogfunctions/list/hogFunctionListLogic.tsx    | 3 ++-
 frontend/src/scenes/pipeline/hogfunctions/urls.ts          | 3 ++-
 frontend/src/scenes/surveys/SurveyView.tsx                 | 1 +
 frontend/src/scenes/surveys/Surveys.tsx                    | 1 +
 frontend/src/types.ts                                      | 6 +++++-
 11 files changed, 24 insertions(+), 8 deletions(-)

diff --git a/frontend/src/layout/navigation-3000/sidepanel/panels/activity/SidePanelActivitySubscriptions.tsx b/frontend/src/layout/navigation-3000/sidepanel/panels/activity/SidePanelActivitySubscriptions.tsx
index d450e2641e1f5..b2d37cafc39bf 100644
--- a/frontend/src/layout/navigation-3000/sidepanel/panels/activity/SidePanelActivitySubscriptions.tsx
+++ b/frontend/src/layout/navigation-3000/sidepanel/panels/activity/SidePanelActivitySubscriptions.tsx
@@ -6,6 +6,7 @@ export function SidePanelActivitySubscriptions(): JSX.Element {
             <p>Get notified of your team's activity</p>
 
             <LinkedHogFunctions
+                logicKey="activity-log"
                 type="internal_destination"
                 subTemplateId="activity-log"
                 filters={{
diff --git a/frontend/src/scenes/actions/ActionHogFunctions.tsx b/frontend/src/scenes/actions/ActionHogFunctions.tsx
index 6128a2c1d664c..03cc805f8c5e5 100644
--- a/frontend/src/scenes/actions/ActionHogFunctions.tsx
+++ b/frontend/src/scenes/actions/ActionHogFunctions.tsx
@@ -35,6 +35,7 @@ export function ActionHogFunctions(): JSX.Element | null {
             ) : null}
 
             <LinkedHogFunctions
+                logicKey="actions"
                 type="destination"
                 filters={filters}
                 newDisabledReason={
diff --git a/frontend/src/scenes/data-management/definition/DefinitionView.tsx b/frontend/src/scenes/data-management/definition/DefinitionView.tsx
index e2f0d0503d6dc..bb74a4c4a71cf 100644
--- a/frontend/src/scenes/data-management/definition/DefinitionView.tsx
+++ b/frontend/src/scenes/data-management/definition/DefinitionView.tsx
@@ -183,7 +183,7 @@ export function DefinitionView(props: DefinitionLogicProps = {}): JSX.Element {
             <LemonDivider className="my-6" />
             <div className="flex flex-wrap">
                 {isEvent && definition.created_at && (
-                    <div className="flex-1 flex flex-col">
+                    <div className="flex flex-col flex-1">
                         <h5>First seen</h5>
                         <b>
                             <TZLabel time={definition.created_at} />
@@ -191,7 +191,7 @@ export function DefinitionView(props: DefinitionLogicProps = {}): JSX.Element {
                     </div>
                 )}
                 {isEvent && definition.last_seen_at && (
-                    <div className="flex-1 flex flex-col">
+                    <div className="flex flex-col flex-1">
                         <h5>Last seen</h5>
                         <b>
                             <TZLabel time={definition.last_seen_at} />
@@ -200,7 +200,7 @@ export function DefinitionView(props: DefinitionLogicProps = {}): JSX.Element {
                 )}
 
                 {isProperty && (
-                    <div className="flex-1 flex flex-col">
+                    <div className="flex flex-col flex-1">
                         <h5>Property type</h5>
                         <b>{(definition as PropertyDefinition).property_type ?? '-'}</b>
                     </div>
@@ -218,6 +218,7 @@ export function DefinitionView(props: DefinitionLogicProps = {}): JSX.Element {
                     <p>Get notified via Slack, webhooks or more whenever this event is captured.</p>
 
                     <LinkedHogFunctions
+                        logicKey="event-definitions"
                         type="destination"
                         filters={{
                             events: [
diff --git a/frontend/src/scenes/early-access-features/EarlyAccessFeature.tsx b/frontend/src/scenes/early-access-features/EarlyAccessFeature.tsx
index cf30eff83213b..1c05472c22b81 100644
--- a/frontend/src/scenes/early-access-features/EarlyAccessFeature.tsx
+++ b/frontend/src/scenes/early-access-features/EarlyAccessFeature.tsx
@@ -331,6 +331,7 @@ export function EarlyAccessFeature({ id }: { id?: string } = {}): JSX.Element {
                         <h3>Notifications</h3>
                         <p>Get notified when people opt in or out of your feature.</p>
                         <LinkedHogFunctions
+                            logicKey="eaf"
                             type="destination"
                             filters={destinationFilters}
                             subTemplateId="early-access-feature-enrollment"
diff --git a/frontend/src/scenes/error-tracking/alerts/ErrorTrackingAlertsScene.tsx b/frontend/src/scenes/error-tracking/alerts/ErrorTrackingAlertsScene.tsx
index 4de3ed0999a1c..0e447a3e287f8 100644
--- a/frontend/src/scenes/error-tracking/alerts/ErrorTrackingAlertsScene.tsx
+++ b/frontend/src/scenes/error-tracking/alerts/ErrorTrackingAlertsScene.tsx
@@ -47,12 +47,13 @@ export function ErrorTrackingAlertsScene(): JSX.Element {
             />
 
             <LinkedHogFunctions
+                logicKey="error-tracking-alerts"
                 type="internal_destination"
-                subTemplateId="activity_log"
+                subTemplateId="errors"
                 filters={{
                     events: [
                         {
-                            id: `$activity_log_entry_created`,
+                            id: `$error_something`,
                             type: 'events',
                         },
                     ],
diff --git a/frontend/src/scenes/pipeline/hogfunctions/list/LinkedHogFunctions.tsx b/frontend/src/scenes/pipeline/hogfunctions/list/LinkedHogFunctions.tsx
index 38ca07adc2798..60af2c21aa1eb 100644
--- a/frontend/src/scenes/pipeline/hogfunctions/list/LinkedHogFunctions.tsx
+++ b/frontend/src/scenes/pipeline/hogfunctions/list/LinkedHogFunctions.tsx
@@ -7,6 +7,7 @@ import { HogFunctionList } from './HogFunctionsList'
 import { HogFunctionTemplateList } from './HogFunctionTemplateList'
 
 export type LinkedHogFunctionsProps = {
+    logicKey?: string
     type: HogFunctionTypeType
     filters: HogFunctionFiltersType
     subTemplateId?: HogFunctionSubTemplateIdType
@@ -14,6 +15,7 @@ export type LinkedHogFunctionsProps = {
 }
 
 export function LinkedHogFunctions({
+    logicKey,
     type,
     filters,
     subTemplateId,
@@ -38,6 +40,7 @@ export function LinkedHogFunctions({
     ) : (
         <HogFunctionList
             forceFilters={{ filters }}
+            logicKey={logicKey}
             type={type}
             extraControls={
                 <>
diff --git a/frontend/src/scenes/pipeline/hogfunctions/list/hogFunctionListLogic.tsx b/frontend/src/scenes/pipeline/hogfunctions/list/hogFunctionListLogic.tsx
index 44a20fdb1900e..a23c47ef000e1 100644
--- a/frontend/src/scenes/pipeline/hogfunctions/list/hogFunctionListLogic.tsx
+++ b/frontend/src/scenes/pipeline/hogfunctions/list/hogFunctionListLogic.tsx
@@ -25,6 +25,7 @@ export type HogFunctionListFilters = {
 }
 
 export type HogFunctionListLogicProps = {
+    logicKey?: string
     type: HogFunctionTypeType
     defaultFilters?: HogFunctionListFilters
     forceFilters?: HogFunctionListFilters
@@ -33,7 +34,7 @@ export type HogFunctionListLogicProps = {
 
 export const hogFunctionListLogic = kea<hogFunctionListLogicType>([
     props({} as HogFunctionListLogicProps),
-    key((props) => (props.syncFiltersWithUrl ? 'scene' : 'default')),
+    key((props) => (props.syncFiltersWithUrl ? 'scene' : 'default') + (props.logicKey || props.type)),
     path((id) => ['scenes', 'pipeline', 'hogFunctionListLogic', id]),
     connect({
         values: [
diff --git a/frontend/src/scenes/pipeline/hogfunctions/urls.ts b/frontend/src/scenes/pipeline/hogfunctions/urls.ts
index 7f8448479adee..3847306c811c9 100644
--- a/frontend/src/scenes/pipeline/hogfunctions/urls.ts
+++ b/frontend/src/scenes/pipeline/hogfunctions/urls.ts
@@ -15,7 +15,8 @@ export function hogFunctionUrl(type: HogFunctionTypeType | PipelineStage, id?: s
         return id ? urls.messagingProvider(id) : urls.messagingProviders()
     } else if (type === 'broadcast') {
         return id ? urls.messagingBroadcast(id) : urls.messagingBroadcasts()
-    } else if (type === 'error_tracking_alert') {
+    } else if (type === 'internal_destination') {
+        // TODO: Fix this somehow
         return urls.errorTrackingAlerts()
     }
     return id
diff --git a/frontend/src/scenes/surveys/SurveyView.tsx b/frontend/src/scenes/surveys/SurveyView.tsx
index 267879c405c43..f31bac21f2987 100644
--- a/frontend/src/scenes/surveys/SurveyView.tsx
+++ b/frontend/src/scenes/surveys/SurveyView.tsx
@@ -415,6 +415,7 @@ export function SurveyView({ id }: { id: string }): JSX.Element {
                                           <div>
                                               <p>Get notified whenever a survey result is submitted</p>
                                               <LinkedHogFunctions
+                                                  logicKey="survey"
                                                   type="destination"
                                                   subTemplateId="survey-response"
                                                   filters={{
diff --git a/frontend/src/scenes/surveys/Surveys.tsx b/frontend/src/scenes/surveys/Surveys.tsx
index 29ab805b66918..1ad5728594bd1 100644
--- a/frontend/src/scenes/surveys/Surveys.tsx
+++ b/frontend/src/scenes/surveys/Surveys.tsx
@@ -196,6 +196,7 @@ export function Surveys(): JSX.Element {
                 <>
                     <p>Get notified whenever a survey result is submitted</p>
                     <LinkedHogFunctions
+                        logicKey="surveys"
                         type="destination"
                         subTemplateId="survey-response"
                         filters={{
diff --git a/frontend/src/types.ts b/frontend/src/types.ts
index 4ca27f28b411d..7b3ff173bbfd0 100644
--- a/frontend/src/types.ts
+++ b/frontend/src/types.ts
@@ -4701,7 +4701,11 @@ export type HogFunctionType = {
 }
 
 export type HogFunctionTemplateStatus = 'alpha' | 'beta' | 'stable' | 'free' | 'deprecated' | 'client-side'
-export type HogFunctionSubTemplateIdType = 'early-access-feature-enrollment' | 'survey-response' | 'activity-log'
+export type HogFunctionSubTemplateIdType =
+    | 'early-access-feature-enrollment'
+    | 'survey-response'
+    | 'activity-log'
+    | 'errors'
 
 export type HogFunctionConfigurationType = Omit<
     HogFunctionType,