Skip to content

Commit

Permalink
Merge branch 'master' into remove-legacy-notebook-icon
Browse files Browse the repository at this point in the history
  • Loading branch information
thmsobrmlr committed Dec 28, 2023
2 parents ef9482e + e2bfdcf commit ebb283d
Show file tree
Hide file tree
Showing 41 changed files with 173 additions and 1,119 deletions.
7 changes: 2 additions & 5 deletions .storybook/storybook.scss
Original file line number Diff line number Diff line change
Expand Up @@ -4,16 +4,13 @@
.ant-modal-wrap {
z-index: 1050 !important;
}

.ant-select-dropdown,
.ant-picker-dropdown {
z-index: 1060 !important;
}

.ant-tooltip {
z-index: 1060 !important;
}
}

// allow taking screenshots of a scene's main content without overlapping top bar
.TopBar {
position: relative !important;
}
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified frontend/__snapshots__/lemon-ui-icons--shelf-m--dark.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified frontend/__snapshots__/lemon-ui-icons--shelf-m--light.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 0 additions & 4 deletions frontend/src/layout/ErrorBoundary/ErrorBoundary.scss
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,6 @@
background: var(--danger-highlight);
border-radius: var(--radius);

.main-app-content > & {
margin: 1.5rem 0;
}

h2 {
margin-bottom: 0.75rem;
font-weight: 600;
Expand Down
4 changes: 2 additions & 2 deletions frontend/src/layout/navigation-3000/Navigation.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import './Navigation.scss'
import clsx from 'clsx'
import { useMountedLogic, useValues } from 'kea'
import { BillingAlertsV2 } from 'lib/components/BillingAlertsV2'
import { CommandPalette } from 'lib/components/CommandPalette/CommandPalette'
import { CommandBar } from 'lib/components/CommandBar/CommandBar'
import { FlaggedFeature } from 'lib/components/FlaggedFeature'
import { FEATURE_FLAGS } from 'lib/constants'
import { ReactNode, useEffect } from 'react'
Expand Down Expand Up @@ -66,7 +66,7 @@ export function Navigation({
</div>
</main>
{!mobileLayout && <SidePanel />}
<CommandPalette />
<CommandBar />
</div>
)
}
2 changes: 0 additions & 2 deletions frontend/src/layout/navigation-3000/components/TopBar.scss
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
// TODO: Remove legacy scss files
@import '../../navigation/TopBar/TopBar';
@import '../../navigation/SideBar/SideBar';
@import '../../navigation/Breadcrumbs/Breadcrumbs';

.TopBar3000 {
--breadcrumbs-compaction-rate: 0;
Expand Down

This file was deleted.

This file was deleted.

34 changes: 0 additions & 34 deletions frontend/src/layout/navigation/Breadcrumbs/Breadcrumbs.scss

This file was deleted.

72 changes: 0 additions & 72 deletions frontend/src/layout/navigation/Breadcrumbs/Breadcrumbs.tsx

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
import './Breadcrumbs.scss'

import { actions, connect, kea, listeners, path, props, reducers, selectors } from 'kea'
import { subscriptions } from 'kea-subscriptions'
import { Lettermark } from 'lib/lemon-ui/Lettermark'
Expand Down
91 changes: 0 additions & 91 deletions frontend/src/layout/navigation/Navigation.stories.tsx

This file was deleted.

40 changes: 4 additions & 36 deletions frontend/src/layout/navigation/Navigation.tsx
Original file line number Diff line number Diff line change
@@ -1,41 +1,9 @@
import clsx from 'clsx'
import { BillingAlertsV2 } from 'lib/components/BillingAlertsV2'
import { ReactNode } from 'react'
import { SceneConfig } from 'scenes/sceneTypes'

import { Breadcrumbs } from './Breadcrumbs/Breadcrumbs'
import { ProjectNotice } from './ProjectNotice'
import { SideBar } from './SideBar/SideBar'
import { TopBar } from './TopBar/TopBar'

export function Navigation({
children,
sceneConfig,
}: {
children: ReactNode
sceneConfig: SceneConfig | null
}): JSX.Element {
export function Navigation(): JSX.Element {
return (
<div className="h-screen flex flex-col">
<TopBar />
<SideBar>
<div
className={clsx(
'main-app-content',
sceneConfig?.layout === 'plain' && 'main-app-content--plain',
sceneConfig?.layout === 'app-container' && 'main-app-content--container'
)}
>
{sceneConfig?.layout !== 'plain' && (
<>
<BillingAlertsV2 />
{!sceneConfig?.hideProjectNotice && <ProjectNotice />}
<Breadcrumbs />
</>
)}
{children}
</div>
</SideBar>
</div>
<SideBar>
<div />
</SideBar>
)
}
Loading

0 comments on commit ebb283d

Please sign in to comment.