-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge branch 'master' into remove-legacy-notebook-icon
- Loading branch information
Showing
41 changed files
with
173 additions
and
1,119 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file modified
BIN
+19.9 KB
(160%)
frontend/__snapshots__/layout-navigation--app-page-with-side-bar-hidden--dark.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+18.9 KB
(150%)
frontend/__snapshots__/layout-navigation--app-page-with-side-bar-hidden--light.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-9.59 KB
(85%)
frontend/__snapshots__/layout-navigation--app-page-with-side-bar-shown--dark.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-11.3 KB
(83%)
frontend/__snapshots__/layout-navigation--app-page-with-side-bar-shown--light.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
70 changes: 0 additions & 70 deletions
70
frontend/src/layout/navigation-3000/sidepanel/panels/activity/NotificationBell.tsx
This file was deleted.
Oops, something went wrong.
4 changes: 0 additions & 4 deletions
4
frontend/src/layout/navigation-3000/sidepanel/panels/activity/NotificationsBell.scss
This file was deleted.
Oops, something went wrong.
34 changes: 0 additions & 34 deletions
34
frontend/src/layout/navigation/Breadcrumbs/Breadcrumbs.scss
This file was deleted.
Oops, something went wrong.
72 changes: 0 additions & 72 deletions
72
frontend/src/layout/navigation/Breadcrumbs/Breadcrumbs.tsx
This file was deleted.
Oops, something went wrong.
2 changes: 0 additions & 2 deletions
2
frontend/src/layout/navigation/Breadcrumbs/breadcrumbsLogic.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,41 +1,9 @@ | ||
import clsx from 'clsx' | ||
import { BillingAlertsV2 } from 'lib/components/BillingAlertsV2' | ||
import { ReactNode } from 'react' | ||
import { SceneConfig } from 'scenes/sceneTypes' | ||
|
||
import { Breadcrumbs } from './Breadcrumbs/Breadcrumbs' | ||
import { ProjectNotice } from './ProjectNotice' | ||
import { SideBar } from './SideBar/SideBar' | ||
import { TopBar } from './TopBar/TopBar' | ||
|
||
export function Navigation({ | ||
children, | ||
sceneConfig, | ||
}: { | ||
children: ReactNode | ||
sceneConfig: SceneConfig | null | ||
}): JSX.Element { | ||
export function Navigation(): JSX.Element { | ||
return ( | ||
<div className="h-screen flex flex-col"> | ||
<TopBar /> | ||
<SideBar> | ||
<div | ||
className={clsx( | ||
'main-app-content', | ||
sceneConfig?.layout === 'plain' && 'main-app-content--plain', | ||
sceneConfig?.layout === 'app-container' && 'main-app-content--container' | ||
)} | ||
> | ||
{sceneConfig?.layout !== 'plain' && ( | ||
<> | ||
<BillingAlertsV2 /> | ||
{!sceneConfig?.hideProjectNotice && <ProjectNotice />} | ||
<Breadcrumbs /> | ||
</> | ||
)} | ||
{children} | ||
</div> | ||
</SideBar> | ||
</div> | ||
<SideBar> | ||
<div /> | ||
</SideBar> | ||
) | ||
} |
Oops, something went wrong.