From e2387f8a007c512df88d617faf9a59bbd79dcd09 Mon Sep 17 00:00:00 2001 From: David Newell Date: Tue, 31 Oct 2023 17:47:24 +0000 Subject: [PATCH] drop eslint back to warn --- .eslintrc.js | 2 +- .../CohortFilters/CohortCriteriaGroups.tsx | 2 +- .../CohortFilters/CohortCriteriaRowBuilder.tsx | 2 +- .../scenes/dashboard/DashboardCollaborators.tsx | 7 +------ .../scenes/dashboard/dashboards/NoDashboards.tsx | 4 ++-- .../ExperimentImplementationDetails.tsx | 2 +- .../src/scenes/experiments/ExperimentPreview.tsx | 2 +- frontend/src/scenes/feature-flags/FeatureFlag.tsx | 2 +- .../scenes/funnels/FunnelBarGraph/MetricRow.tsx | 2 +- .../scenes/insights/views/Histogram/Histogram.tsx | 1 + .../instance/DeadLetterQueue/MetricsTab.tsx | 7 +------ .../instance/SystemStatus/KafkaInspectorTab.tsx | 6 ++---- .../instance/SystemStatus/StaffUsersTab.tsx | 15 ++++----------- .../src/scenes/organization/Settings/Invites.tsx | 2 +- .../Settings/Permissions/Permissions.tsx | 2 +- .../Settings/Permissions/Roles/Roles.tsx | 2 +- .../Settings/VerifiedDomains/VerifiedDomains.tsx | 2 +- frontend/src/scenes/plugins/edit/PluginField.tsx | 2 +- .../src/scenes/plugins/plugin/PluginImage.tsx | 1 + frontend/src/scenes/plugins/plugin/PluginLogs.tsx | 12 ++++++------ .../src/scenes/plugins/source/PluginSource.tsx | 4 ++-- .../tabs/apps/InstalledAppsReorderModal.tsx | 1 + .../scenes/project/Settings/ExtraTeamSettings.tsx | 2 +- frontend/src/scenes/project/Settings/index.tsx | 2 +- .../player/controller/Seekbar.tsx | 2 +- .../scenes/session-recordings/player/icons.tsx | 2 +- frontend/src/scenes/surveys/SurveyEdit.tsx | 10 ++-------- frontend/src/scenes/surveys/SurveyView.tsx | 2 +- 28 files changed, 40 insertions(+), 62 deletions(-) diff --git a/.eslintrc.js b/.eslintrc.js index a8cab4bc51100..4fddbfc6a37f2 100644 --- a/.eslintrc.js +++ b/.eslintrc.js @@ -86,7 +86,7 @@ module.exports = { }, ], 'react/forbid-dom-props': [ - 'error', + 'warn', { forbid: [ { diff --git a/frontend/src/scenes/cohorts/CohortFilters/CohortCriteriaGroups.tsx b/frontend/src/scenes/cohorts/CohortFilters/CohortCriteriaGroups.tsx index 2b224341715ae..85696488784ae 100644 --- a/frontend/src/scenes/cohorts/CohortFilters/CohortCriteriaGroups.tsx +++ b/frontend/src/scenes/cohorts/CohortFilters/CohortCriteriaGroups.tsx @@ -48,7 +48,7 @@ export function CohortCriteriaGroups(logicProps: CohortLogicProps): JSX.Element onChange={(value) => setInnerGroupType(value, groupIndex)} value={group.type} /> -
+
} status="primary-alt" diff --git a/frontend/src/scenes/cohorts/CohortFilters/CohortCriteriaRowBuilder.tsx b/frontend/src/scenes/cohorts/CohortFilters/CohortCriteriaRowBuilder.tsx index 07a5db01a4dbf..f767a78fb4b03 100644 --- a/frontend/src/scenes/cohorts/CohortFilters/CohortCriteriaRowBuilder.tsx +++ b/frontend/src/scenes/cohorts/CohortFilters/CohortCriteriaRowBuilder.tsx @@ -121,7 +121,7 @@ export function CohortCriteriaRowBuilder({ /> )} -
+
diff --git a/frontend/src/scenes/dashboard/DashboardCollaborators.tsx b/frontend/src/scenes/dashboard/DashboardCollaborators.tsx index 2c91d4ff3000c..4f13b597f8fee 100644 --- a/frontend/src/scenes/dashboard/DashboardCollaborators.tsx +++ b/frontend/src/scenes/dashboard/DashboardCollaborators.tsx @@ -88,12 +88,7 @@ export function DashboardCollaboration({ dashboardId }: { dashboardId: Dashboard
)}
Project members with access
-
+
{allCollaborators.map((collaborator) => ( { }) } > -
+
@@ -36,7 +36,7 @@ export const NoDashboards = (): JSX.Element => { }) } > -
+
diff --git a/frontend/src/scenes/experiments/ExperimentImplementationDetails.tsx b/frontend/src/scenes/experiments/ExperimentImplementationDetails.tsx index 9653d430b1682..8582017bb7bcb 100644 --- a/frontend/src/scenes/experiments/ExperimentImplementationDetails.tsx +++ b/frontend/src/scenes/experiments/ExperimentImplementationDetails.tsx @@ -111,7 +111,7 @@ export function ExperimentImplementationDetails({ experiment }: ExperimentImplem title={Feature flag usage and implementation} className="experiment-implementation-details" > -
+
Variant group ) : ( - + Unknown field type "{fieldConfig.type}".
You may need to upgrade PostHog! diff --git a/frontend/src/scenes/plugins/plugin/PluginImage.tsx b/frontend/src/scenes/plugins/plugin/PluginImage.tsx index 67120a11074d8..9fec8b6275e9e 100644 --- a/frontend/src/scenes/plugins/plugin/PluginImage.tsx +++ b/frontend/src/scenes/plugins/plugin/PluginImage.tsx @@ -42,6 +42,7 @@ export function PluginImage({ ) : (
{type} + return {type} } const columns: ResizableColumnType[] = [ diff --git a/frontend/src/scenes/plugins/source/PluginSource.tsx b/frontend/src/scenes/plugins/source/PluginSource.tsx index f7a9e283bcef9..248d5f13b385b 100644 --- a/frontend/src/scenes/plugins/source/PluginSource.tsx +++ b/frontend/src/scenes/plugins/source/PluginSource.tsx @@ -79,7 +79,7 @@ export function PluginSource({ title={pluginSourceLoading ? 'Loading...' : `Edit App: ${name}`} placement={placement ?? 'left'} footer={ -
+
@@ -125,7 +125,7 @@ export function PluginSource({ }} /> {!value && createDefaultPluginSource(name)[currentFile] ? ( -
+
diff --git a/frontend/src/scenes/plugins/tabs/apps/InstalledAppsReorderModal.tsx b/frontend/src/scenes/plugins/tabs/apps/InstalledAppsReorderModal.tsx index 1e5e0ad81b897..382a157bbbf6f 100644 --- a/frontend/src/scenes/plugins/tabs/apps/InstalledAppsReorderModal.tsx +++ b/frontend/src/scenes/plugins/tabs/apps/InstalledAppsReorderModal.tsx @@ -16,6 +16,7 @@ const MinimalAppView = ({ plugin, order }: { plugin: PluginTypeWithConfig; order
+
+
- {/* eslint-disable-next-line react/forbid-dom-props */}
{/* eslint-disable-next-line react/forbid-dom-props */} diff --git a/frontend/src/scenes/session-recordings/player/icons.tsx b/frontend/src/scenes/session-recordings/player/icons.tsx index 6fff14ba753b5..fa8a79d631150 100644 --- a/frontend/src/scenes/session-recordings/player/icons.tsx +++ b/frontend/src/scenes/session-recordings/player/icons.tsx @@ -10,7 +10,7 @@ export function IconWindowOld({ value, className = '', size = 'medium' }: IconWi const shortValue = typeof value === 'number' ? value : String(value).charAt(0) return (
- + {shortValue} -
+
@@ -929,7 +923,7 @@ export default function SurveyEdit(): JSX.Element { />
-
+
)} {survey.type !== SurveyType.API ? ( -
+