diff --git a/frontend/__snapshots__/components-cards-insight-card--insight-card--dark.png b/frontend/__snapshots__/components-cards-insight-card--insight-card--dark.png index 216ebe2998ef3..1cf7b477f91e7 100644 Binary files a/frontend/__snapshots__/components-cards-insight-card--insight-card--dark.png and b/frontend/__snapshots__/components-cards-insight-card--insight-card--dark.png differ diff --git a/frontend/__snapshots__/components-cards-insight-card--insight-card--light.png b/frontend/__snapshots__/components-cards-insight-card--insight-card--light.png index 210a97aab7b4d..c219df6b34aac 100644 Binary files a/frontend/__snapshots__/components-cards-insight-card--insight-card--light.png and b/frontend/__snapshots__/components-cards-insight-card--insight-card--light.png differ diff --git a/frontend/__snapshots__/exporter-exporter--trends-line-insight-detailed--dark.png b/frontend/__snapshots__/exporter-exporter--trends-line-insight-detailed--dark.png index 80f11e3545900..0ab5e4ed6406e 100644 Binary files a/frontend/__snapshots__/exporter-exporter--trends-line-insight-detailed--dark.png and b/frontend/__snapshots__/exporter-exporter--trends-line-insight-detailed--dark.png differ diff --git a/frontend/__snapshots__/exporter-exporter--trends-line-insight-detailed--light.png b/frontend/__snapshots__/exporter-exporter--trends-line-insight-detailed--light.png index e6eb173228a49..58585281416a5 100644 Binary files a/frontend/__snapshots__/exporter-exporter--trends-line-insight-detailed--light.png and b/frontend/__snapshots__/exporter-exporter--trends-line-insight-detailed--light.png differ diff --git a/frontend/__snapshots__/exporter-exporter--user-paths-insight--dark.png b/frontend/__snapshots__/exporter-exporter--user-paths-insight--dark.png deleted file mode 100644 index acc74d32b1329..0000000000000 Binary files a/frontend/__snapshots__/exporter-exporter--user-paths-insight--dark.png and /dev/null differ diff --git a/frontend/__snapshots__/exporter-exporter--user-paths-insight--light.png b/frontend/__snapshots__/exporter-exporter--user-paths-insight--light.png deleted file mode 100644 index 7a1a6ee0a0a6b..0000000000000 Binary files a/frontend/__snapshots__/exporter-exporter--user-paths-insight--light.png and /dev/null differ diff --git a/frontend/src/exporter/Exporter.stories.tsx b/frontend/src/exporter/Exporter.stories.tsx index 00cc83dc74c57..7dba408f0cdd7 100644 --- a/frontend/src/exporter/Exporter.stories.tsx +++ b/frontend/src/exporter/Exporter.stories.tsx @@ -39,7 +39,6 @@ const Template: StoryFn = (props) => { ) } -Template.tags = ['test-skip'] // :FIXME: flaky tests, most likely due to resize observer changes export const TrendsLineInsight: Story = Template.bind({}) TrendsLineInsight.args = { insight: require('../mocks/fixtures/api/projects/team_id/insights/trendsLine.json') } @@ -202,6 +201,7 @@ StickinessInsight.tags = ['test-skip'] // doesn't produce a helpful reference im export const UserPathsInsight: Story = Template.bind({}) UserPathsInsight.args = { insight: require('../mocks/fixtures/api/projects/team_id/insights/userPaths.json') } +UserPathsInsight.tags = ['test-skip'] // FIXME: flaky tests, most likely due to resize observer changes export const Dashboard: Story = Template.bind({}) Dashboard.args = { dashboard } diff --git a/frontend/src/lib/components/Cards/InsightCard/InsightCard.stories.tsx b/frontend/src/lib/components/Cards/InsightCard/InsightCard.stories.tsx index b2e68d9bd6715..6ffbcf8f51e94 100644 --- a/frontend/src/lib/components/Cards/InsightCard/InsightCard.stories.tsx +++ b/frontend/src/lib/components/Cards/InsightCard/InsightCard.stories.tsx @@ -17,7 +17,6 @@ import EXAMPLE_TRENDS_PIE from '../../../../mocks/fixtures/api/projects/team_id/ import EXAMPLE_TRENDS_TABLE from '../../../../mocks/fixtures/api/projects/team_id/insights/trendsTable.json' import EXAMPLE_TRENDS_HORIZONTAL_BAR from '../../../../mocks/fixtures/api/projects/team_id/insights/trendsValue.json' import EXAMPLE_TRENDS_WORLD_MAP from '../../../../mocks/fixtures/api/projects/team_id/insights/trendsWorldMap.json' -import EXAMPLE_PATHS from '../../../../mocks/fixtures/api/projects/team_id/insights/userPaths.json' import { InsightCard as InsightCardComponent } from './index' const examples = [ @@ -30,7 +29,6 @@ const examples = [ EXAMPLE_TRENDS_WORLD_MAP, EXAMPLE_FUNNEL, EXAMPLE_RETENTION, - EXAMPLE_PATHS, EXAMPLE_STICKINESS, EXAMPLE_LIFECYCLE, EXAMPLE_DATA_TABLE_NODE_HOGQL_QUERY, @@ -64,7 +62,6 @@ const meta: Meta = { control: { type: 'boolean' }, }, }, - tags: ['test-skip'], // :FIXME: flaky tests, most likely due to resize observer changes } export default meta export const InsightCard: Story = (args) => { diff --git a/frontend/src/queries/nodes/InsightViz/InsightViz.tsx b/frontend/src/queries/nodes/InsightViz/InsightViz.tsx index 7bbd78602377c..694c206dd1333 100644 --- a/frontend/src/queries/nodes/InsightViz/InsightViz.tsx +++ b/frontend/src/queries/nodes/InsightViz/InsightViz.tsx @@ -3,7 +3,7 @@ import './InsightViz.scss' import clsx from 'clsx' import { BindLogic, useValues } from 'kea' import { useFeatureFlag } from 'lib/hooks/useFeatureFlag' -import React, { useState } from 'react' +import { useState } from 'react' import { insightLogic } from 'scenes/insights/insightLogic' import { insightSceneLogic } from 'scenes/insights/insightSceneLogic' import { insightVizDataLogic } from 'scenes/insights/insightVizDataLogic' @@ -78,9 +78,19 @@ export function InsightViz({ uniqueKey, query, setQuery, context, readOnly, embe const showingResults = query.showResults ?? true const isEmbedded = embedded || (query.embedded ?? false) - const Wrapper = ({ children }: { children: React.ReactElement }): JSX.Element => { - return isEmbedded ? <>{children} :
{children}
- } + const display = ( + + ) return ( @@ -98,20 +108,7 @@ export function InsightViz({ uniqueKey, query, setQuery, context, readOnly, embe {!readOnly && ( )} - - - - + {!isEmbedded ?
{display}
: display}