diff --git a/frontend/__snapshots__/scenes-app-recordings--recordings-play-list-no-pinned-recordings.png b/frontend/__snapshots__/scenes-app-recordings--recordings-play-list-no-pinned-recordings.png index bba83afd7cd8d..55b81bc98fcce 100644 Binary files a/frontend/__snapshots__/scenes-app-recordings--recordings-play-list-no-pinned-recordings.png and b/frontend/__snapshots__/scenes-app-recordings--recordings-play-list-no-pinned-recordings.png differ diff --git a/frontend/src/lib/components/Subscriptions/views/EditSubscription.tsx b/frontend/src/lib/components/Subscriptions/views/EditSubscription.tsx index 2550bcff4d546..7034d975c324b 100644 --- a/frontend/src/lib/components/Subscriptions/views/EditSubscription.tsx +++ b/frontend/src/lib/components/Subscriptions/views/EditSubscription.tsx @@ -285,7 +285,7 @@ export function EditSubscription({ > {({ value, onChange }) => ( onChange(val)} + onChange={(val: string) => onChange(val)} value={value} disabled={slackDisabled} mode="single" diff --git a/frontend/src/lib/lemon-ui/LemonSelectMultiple/LemonSelectMultiple.tsx b/frontend/src/lib/lemon-ui/LemonSelectMultiple/LemonSelectMultiple.tsx index 4bec9b6b1002d..49bee6c0f3589 100644 --- a/frontend/src/lib/lemon-ui/LemonSelectMultiple/LemonSelectMultiple.tsx +++ b/frontend/src/lib/lemon-ui/LemonSelectMultiple/LemonSelectMultiple.tsx @@ -18,20 +18,20 @@ export interface LemonSelectMultipleOptionItem extends LemonSelectMultipleOption export type LemonSelectMultipleOptions = Record -export interface LemonSelectMultipleProps { +export type LemonSelectMultipleProps = { selectClassName?: string options?: LemonSelectMultipleOptions | LemonSelectMultipleOptionItem[] - value?: string[] | null | LabelInValue[] + value?: string | string[] | null disabled?: boolean loading?: boolean placeholder?: string labelInValue?: boolean - onChange?: ((newValue: string[]) => void) | ((newValue: LabelInValue[]) => void) onSearch?: (value: string) => void onFocus?: () => void onBlur?: () => void filterOption?: boolean mode?: 'single' | 'multiple' | 'multiple-custom' + onChange?: ((newValue: string) => void) | ((newValue: string[]) => void) 'data-attr'?: string } @@ -82,9 +82,10 @@ export function LemonSelectMultiple({ showAction={['focus']} onChange={(v) => { if (onChange) { - if (labelInValue) { - const typedValues = v as LabelInValue[] - const typedOnChange = onChange as (newValue: LabelInValue[]) => void + // TRICKY: V is typed poorly and will be a string if the "mode" is undefined + if (!v || typeof v === 'string') { + const typedValues = v as string | null + const typedOnChange = onChange as (newValue: string | null) => void typedOnChange(typedValues) } else { const typedValues = v.map((token) => token.toString().trim()) as string[] diff --git a/frontend/src/scenes/project/Settings/TimezoneConfig.tsx b/frontend/src/scenes/project/Settings/TimezoneConfig.tsx index bb7a61871f180..09d7c8a70c026 100644 --- a/frontend/src/scenes/project/Settings/TimezoneConfig.tsx +++ b/frontend/src/scenes/project/Settings/TimezoneConfig.tsx @@ -32,7 +32,7 @@ export function TimezoneConfig(): JSX.Element { loading={currentTeamLoading} disabled={currentTeamLoading} value={[currentTeam.timezone]} - onChange={(newTimezone: any): void => { + onChange={(newTimezone: string): void => { // This is a string for a single-mode select, but typing is poor if (!preflight?.available_timezones) { throw new Error('No timezones are available')