Skip to content

Commit

Permalink
Remove button from breadcrumbs and correct icons
Browse files Browse the repository at this point in the history
  • Loading branch information
benjackwhite committed Oct 26, 2023
1 parent 6619e07 commit c79e2f5
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,6 @@ import { Popover } from 'lib/lemon-ui/Popover/Popover'
import { breadcrumbsLogic } from '~/layout/navigation/Breadcrumbs/breadcrumbsLogic'
import { LemonButton } from '@posthog/lemon-ui'
import { NewInsightButton } from 'scenes/saved-insights/SavedInsights'
import { NotebookButton } from '~/layout/navigation/TopBar/NotebookButton'
import { FlaggedFeature } from 'lib/components/FlaggedFeature'
import { FEATURE_FLAGS } from 'lib/constants'

/**
* In PostHog 3000 breadcrumbs also serve as the top bar. This is marked by theses two features:
Expand All @@ -33,9 +30,6 @@ export function Breadcrumbs(): JSX.Element | null {
{/* TODO: These buttons below are hardcoded right now, scene-based system coming in the next PR */}
<LemonButton className="Breadcrumbs3000__more" icon={<IconEllipsisVertical />} size="small" />
<div className="Breadcrumbs3000__actions">
<FlaggedFeature flag={FEATURE_FLAGS.NOTEBOOKS}>
<NotebookButton />
</FlaggedFeature>
<NewInsightButton dataAttr="project-home-new-insight" />
</div>
</div>
Expand Down
6 changes: 3 additions & 3 deletions frontend/src/layout/navigation-3000/sidepanel/SidePanel.tsx
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
import { LemonButton } from '@posthog/lemon-ui'
import './SidePanel.scss'
import { IconComment, IconNotebook } from 'lib/lemon-ui/icons'
import { IconNotebook, IconQuestion } from '@posthog/icons'

export function SidePanel(): JSX.Element {
return (
<nav className="SidePanel3000">
<div className="SidePanel3000__content">
<div className="SidePanel3000__top">
<div className="rotate-90 flex items-center gap-2 px-2">
<LemonButton icon={<IconNotebook className="rotate-270" />}>Notebooks</LemonButton>
<LemonButton icon={<IconComment className="rotate-270" />}>Feedback</LemonButton>
<LemonButton icon={<IconNotebook className="rotate-270 w-6" />}>Notebooks</LemonButton>
<LemonButton icon={<IconQuestion className="rotate-270 w-6" />}>Feedback</LemonButton>
</div>
</div>
</div>
Expand Down

0 comments on commit c79e2f5

Please sign in to comment.