diff --git a/frontend/src/lib/components/Cards/InsightCard/InsightCard.tsx b/frontend/src/lib/components/Cards/InsightCard/InsightCard.tsx index 0645e13e1ce03..338c53bb14401 100644 --- a/frontend/src/lib/components/Cards/InsightCard/InsightCard.tsx +++ b/frontend/src/lib/components/Cards/InsightCard/InsightCard.tsx @@ -164,7 +164,7 @@ function VizComponentFallback(): JSX.Element { } export interface FilterBasedCardContentProps - extends Pick { + extends Pick { insightProps: InsightLogicProps tooFewFunnelSteps?: boolean validationError?: string | null @@ -177,7 +177,6 @@ export interface FilterBasedCardContentProps export function FilterBasedCardContent({ insight, insightProps, - loadingQueued, loading, setAreDetailsShown, apiErrored, @@ -212,7 +211,6 @@ export function FilterBasedCardContent({ } > {loading && } - {loadingQueued && !loading && } {tooFewFunnelSteps ? ( ) : validationError ? ( @@ -311,6 +309,7 @@ function InsightCardInternal( removeFromDashboard={removeFromDashboard} deleteWithUndo={deleteWithUndo} refresh={refresh} + loading={loadingQueued || loading} rename={rename} duplicate={duplicate} moveToDashboard={moveToDashboard} @@ -334,7 +333,6 @@ function InsightCardInternal(

{name || {summary}} + {loading && ( + + + + Refreshing + + + )}

{!!insight.description &&
{insight.description}
} {insight.tags && insight.tags.length > 0 && } + + {loading && } } metaDetails={}