From af439b28200bb582a201c0e638098d628a17db28 Mon Sep 17 00:00:00 2001 From: Juraj Majerik Date: Tue, 16 Apr 2024 13:01:55 +0200 Subject: [PATCH] fix redundant Math.min() --- frontend/src/scenes/experiments/ExperimentView/components.tsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/frontend/src/scenes/experiments/ExperimentView/components.tsx b/frontend/src/scenes/experiments/ExperimentView/components.tsx index d1308a68f9060..2cc4d7ab88baf 100644 --- a/frontend/src/scenes/experiments/ExperimentView/components.tsx +++ b/frontend/src/scenes/experiments/ExperimentView/components.tsx @@ -417,7 +417,7 @@ export function ActionBanner(): JSX.Element { // Win probability only slightly over 0.9 and the recommended sample/time just met -> proceed with caution if ( experimentInsightType === InsightType.FUNNELS && - funnelResultsPersonsTotal > Math.min(recommendedSampleSize) + 50 && + funnelResultsPersonsTotal > recommendedSampleSize + 50 && winProbability < 0.93 ) { return ( @@ -431,7 +431,7 @@ export function ActionBanner(): JSX.Element { if ( experimentInsightType === InsightType.TRENDS && - actualRunningTime > Math.min(recommendedRunningTime) + 2 && + actualRunningTime > recommendedRunningTime + 2 && winProbability < 0.93 ) { return (