From a0739269852276c734707d74680248fc02ef11c4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Thomas=20Obermu=CC=88ller?= Date: Tue, 7 Nov 2023 16:39:54 +0000 Subject: [PATCH] remove propsQuery --- frontend/src/scenes/insights/insightDataLogic.ts | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/frontend/src/scenes/insights/insightDataLogic.ts b/frontend/src/scenes/insights/insightDataLogic.ts index e2ac23f175ed2..153be0b0b27c3 100644 --- a/frontend/src/scenes/insights/insightDataLogic.ts +++ b/frontend/src/scenes/insights/insightDataLogic.ts @@ -84,21 +84,14 @@ export const insightDataLogic = kea([ selectors({ query: [ - (s) => [s.propsQuery, s.filters, s.insight, s.internalQuery, s.filterTestAccountsDefault], - (propsQuery, filters, insight, internalQuery, filterTestAccountsDefault) => - propsQuery || + (s) => [s.filters, s.insight, s.internalQuery, s.filterTestAccountsDefault], + (filters, insight, internalQuery, filterTestAccountsDefault) => internalQuery || insight.query || (filters && filters.insight ? queryFromFilters(filters) : undefined) || queryFromKind(NodeKind.TrendsQuery, filterTestAccountsDefault), ], - propsQuery: [ - () => [(_, props) => props], - // overwrite query from props for standalone InsightVizNode queries - (props: InsightLogicProps) => (props.dashboardItemId?.startsWith('new-AdHoc.') ? props.query : null), - ], - isQueryBasedInsight: [ (s) => [s.query], (query) => {