From 8ab153fa2f870dee67ec71734501aea09c402290 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tom=C3=A1s=20Far=C3=ADas=20Santana?= Date: Fri, 15 Sep 2023 13:27:07 +0200 Subject: [PATCH] feat: Enable brotli compression in S3 batch exports configuration (#17463) --- frontend/src/scenes/batch_exports/BatchExportEditForm.tsx | 1 + .../tests/batch_exports/test_s3_batch_export_workflow.py | 4 +++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/frontend/src/scenes/batch_exports/BatchExportEditForm.tsx b/frontend/src/scenes/batch_exports/BatchExportEditForm.tsx index 2ce88feaaddfb..be8f7d9c64016 100644 --- a/frontend/src/scenes/batch_exports/BatchExportEditForm.tsx +++ b/frontend/src/scenes/batch_exports/BatchExportEditForm.tsx @@ -190,6 +190,7 @@ export function BatchExportsEditForm(props: BatchExportsEditLogicProps): JSX.Ele diff --git a/posthog/temporal/tests/batch_exports/test_s3_batch_export_workflow.py b/posthog/temporal/tests/batch_exports/test_s3_batch_export_workflow.py index cb38d818ba9d7..b4e51bc9f8b8e 100644 --- a/posthog/temporal/tests/batch_exports/test_s3_batch_export_workflow.py +++ b/posthog/temporal/tests/batch_exports/test_s3_batch_export_workflow.py @@ -444,7 +444,7 @@ async def test_s3_export_workflow_with_minio_bucket( @pytest.mark.asyncio @pytest.mark.parametrize( "interval,compression,encryption,exclude_events", - itertools.product(["hour", "day"], [None, "gzip", "brotli"], [None, "AES256"], [None, ["test-exclude"]]), + itertools.product(["hour", "day"], [None, "gzip", "brotli"], [None, "AES256", "aws:kms"], [None, ["test-exclude"]]), ) async def test_s3_export_workflow_with_s3_bucket(interval, compression, encryption, exclude_events): """Test S3 Export Workflow end-to-end by using an S3 bucket. @@ -457,6 +457,7 @@ async def test_s3_export_workflow_with_s3_bucket(interval, compression, encrypti records to the S3 bucket. """ bucket_name = os.getenv("S3_TEST_BUCKET") + kms_key_id = os.getenv("S3_TEST_KMS_KEY_ID") prefix = f"posthog-events-{str(uuid4())}" destination_data = { "type": "S3", @@ -469,6 +470,7 @@ async def test_s3_export_workflow_with_s3_bucket(interval, compression, encrypti "compression": compression, "exclude_events": exclude_events, "encryption": encryption, + "kms_key_id": kms_key_id if encryption == "aws:kms" else None, }, }